Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[css-animations-2] should animation-composition be taken into account when merging keyframes? #6935

Closed
graouts opened this issue Jan 6, 2022 · 2 comments
Closed

[css-animations-2] should animation-composition be taken into account when merging keyframes? #6935

graouts opened this issue Jan 6, 2022 · 2 comments
Assignees
@dbaron @flackr @birtles
Labels
css-animations-2

Comments

@graouts
Copy link
Contributor

graouts commented Jan 6, 2022 •
edited

The Keyframes section of the CSS Animations Level 2 spec discusses how animation-timing-function applied to individual keyframes should be account for along with the offset to merge keyframes with similar offset and easing.

Should animation-composition also be accounted for here such that only keyframes with the same offset, canonical timing function and composite operation be merged?
@graouts graouts mentioned this issue Jan 6, 2022
Merged
graouts added a commit to graouts/wpt that referenced this issue Jan 7, 2022
@graouts
Add testing coverage for keyframe de-duplication accounting for anima…
3343e4f 
…tion-composition.

This is discussed in w3c/csswg-drafts#6935.
graouts added a commit to graouts/wpt that referenced this issue Jan 7, 2022
@graouts
Add testing coverage for animation-composition included in the animat…
9b0d0d4 
…ion shorthand.

This is being discussed by w3c/csswg-drafts#6935.
@graouts
Copy link
Contributor Author

graouts commented Jan 7, 2022

I have WPT coverage in progress in graouts/wpt@3343e4f if anyone is curious as to what this would look like in practice.

@birtles
Copy link
Contributor

birtles commented Jan 13, 2022

Should animation-composition also be accounted for here such that only keyframes with the same offset, canonical timing function and composite operation be merged?

I think that makes sense.

graouts added a commit to graouts/csswg-drafts that referenced this issue Jan 21, 2022
@graouts
Account for animation-composition when merging keyframes, addresses w…
47662cc 
…3c#6935.
graouts added a commit to graouts/csswg-drafts that referenced this issue Jan 21, 2022
@graouts
[css-animations-2] Account for animation-composition when merging k…
61ac418 
…eyframes, addresses w3c#6935.
graouts added a commit to graouts/csswg-drafts that referenced this issue Jan 21, 2022
@graouts
[css-animations-2] Account for animation-composition when merging k…
184c40f 
…eyframes (fixes w3c#6935)
@graouts graouts mentioned this issue Jan 21, 2022
Merged
graouts added a commit to graouts/wpt that referenced this issue Jan 21, 2022
@graouts
Add testing coverage for keyframe de-duplication accounting for anima…
cf4ab5c 
…tion-composition.

This is discussed in w3c/csswg-drafts#6935.
graouts added a commit to graouts/wpt that referenced this issue Jan 21, 2022
@graouts
Add testing coverage for animation-composition included in the animat…
b35dff1 
…ion shorthand.

This is being discussed by w3c/csswg-drafts#6935.
graouts added a commit to graouts/wpt that referenced this issue Jan 21, 2022
@graouts
[css-animations-2] Add testing coverage for keyframe de-duplication a…
b5ddd15 
…ccounting for animation-composition

This was discussed in w3c/csswg-drafts#6935.
@graouts graouts mentioned this issue Jan 21, 2022
Merged
graouts added a commit that referenced this issue Jan 24, 2022
@graouts
[css-animations-2] Account for animation-composition when merging k…
4f69b43 
…eyframes (closes #6935)
graouts added a commit to web-platform-tests/wpt that referenced this issue Jan 25, 2022
@graouts
[css-animations-2] Add testing coverage for keyframe de-duplication a…
ca08c81 
…ccounting for animation-composition (#32495)

This was discussed in w3c/csswg-drafts#6935.
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this issue Feb 5, 2022
@graouts @moz-wptsync-bot
Bug 1751437 [wpt PR 32495] - [css-animations-2] Add testing coverage …
8207bd9 
…for keyframe de-duplication accounting for animation-composition, a=testonly

Automatic update from web-platform-tests
[css-animations-2] Add testing coverage for keyframe de-duplication accounting for animation-composition (#32495)

This was discussed in w3c/csswg-drafts#6935.
--

wpt-commits: ca08c8112c862e5dbea899da0bda8ac84d9a201b
wpt-pr: 32495
jamienicol pushed a commit to jamienicol/gecko that referenced this issue Feb 7, 2022
@graouts @moz-wptsync-bot
Bug 1751437 [wpt PR 32495] - [css-animations-2] Add testing coverage …
673415d 
…for keyframe de-duplication accounting for animation-composition, a=testonly

Automatic update from web-platform-tests
[css-animations-2] Add testing coverage for keyframe de-duplication accounting for animation-composition (#32495)

This was discussed in w3c/csswg-drafts#6935.
--

wpt-commits: ca08c8112c862e5dbea899da0bda8ac84d9a201b
wpt-pr: 32495
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dbaron dbaron

@flackr flackr

@birtles birtles

Labels
css-animations-2
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@graouts @dbaron @flackr @birtles