Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should CSSRule.type have a value for CSSPropertyRule? #7154

Closed
gsnedders opened this issue Mar 17, 2022 · 4 comments
Closed

Should CSSRule.type have a value for CSSPropertyRule? #7154

gsnedders opened this issue Mar 17, 2022 · 4 comments
Labels
Closed Accepted as Editorial Commenter Satisfied Commenter has indicated satisfaction with the resolution / edits. cssom-1

Comments

@gsnedders
Copy link
Contributor

c.f. https://www.w3.org/TR/css-properties-values-api-1/#csspropertyrule and https://www.w3.org/TR/cssom/#dom-cssrule-type

This seems to have a near complete list of values, but doesn't have one for CSSPropertyRule? If this is deliberate, can we add a note so people in future don't believe it's an error, or can we add it?

@tabatkins
Copy link
Member

Definitely intentional; see https://wiki.csswg.org/spec/cssom-constants

There already is a note saying that this attribute is legacy, right at the bottom. Do you want it to say something more?

@gsnedders
Copy link
Contributor Author

There already is a note saying that this attribute is legacy, right at the bottom. Do you want it to say something more?

Be explicit that no new values will be added, and that any implementer introducing support for a new CSSRule should not introduce a new return value there.

While it's clear that it's deprecated, it wouldn't be unprecedented for something like that to continue to have new items added, especially by anyone unaware of the history.

@tabatkins
Copy link
Member

Done.

@gsnedders
Copy link
Contributor Author

👍

@tabatkins tabatkins added Commenter Satisfied Commenter has indicated satisfaction with the resolution / edits. Commenter Response Pending and removed Commenter Response Pending labels Mar 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Closed Accepted as Editorial Commenter Satisfied Commenter has indicated satisfaction with the resolution / edits. cssom-1
Projects
None yet
Development

No branches or pull requests

2 participants