Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[css-backgrounds-3] possible typo (border-style→border-color) #7365

Open
lilychen1388 opened this issue Jun 15, 2022 · 3 comments
Open

[css-backgrounds-3] possible typo (border-style→border-color) #7365

lilychen1388 opened this issue Jun 15, 2022 · 3 comments

Comments

@lilychen1388
Copy link

lilychen1388 commented Jun 15, 2022

As title.

In section '3.1. Line Colors: the border-color propertiesr'
It says 'These properties set the foreground color of the border specified by the border-style properties. '
Should it be 'border-color', not 'border-style' ?

by the <span class=property>border-style</span> properties.

There is a same description in css-backgrounds-4 too.

by the 'border-style' properties.

@Loirooriol
Copy link
Contributor

Then we would end up with

The border-color properties set the foreground color of the border specified by the border-color properties.

which doesn't make sense.

border-style specify what kind of border, border-color specify the color for that border.

But if it's confusing I would just trim it to

These properties set the foreground color of the border.

@lilychen1388
Copy link
Author

it's great!
Thank you!

@fantasai
Copy link
Collaborator

Hi @lilychen1388; @SebastianZ outlined in #7488 (comment) that the proposed change makes it a bit less clear, since the border-color property only specifies the foreground color of a border specified via border-style (and not one specified via e.g. border-image). Does that make sense to you? I think I agree that the current wording is more precise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants