Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[css-pseudo] highlight pseudos and compat stroke/fill properties #7580

Open
delan opened this issue Aug 8, 2022 · 2 comments
Open

[css-pseudo] highlight pseudos and compat stroke/fill properties #7580

delan opened this issue Aug 8, 2022 · 2 comments

Comments

@delan
Copy link
Contributor

delan commented Aug 8, 2022

https://drafts.csswg.org/css-pseudo-4/#highlight-styling

The following properties apply to the highlight pseudo-elements:

‘-webkit-text-fill-color’, ‘-webkit-text-stroke-color’, ‘-webkit-text-stroke-width’, and ‘-webkit-text-stroke’ are unrelated to those SVG-only properties, but they work roughly the same way and are supported interoperably. WPT even has a test for ::selection with ‘-webkit-text-fill-color’. Should we make these properties applicable to highlights?

(@fantasai, @frivoal, @mrego)

chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this issue Dec 1, 2022
‘-webkit-text-fill-color’ is valid_for_highlight, but we forgot to
mark ‘-webkit-text-stroke-color’ and ‘-webkit-text-stroke-width’ as
valid_for_highlight too. They are only valid_for_highlight_legacy
at the moment.

Whether all three should be applicable is pending a spec issue [1],
but HighlightInheritance is not stable yet anyway, and enabling them
in this patch unblocks bumping HighlightInheritance to experimental.

[1] w3c/csswg-drafts#7580

Bug: 1024156
Change-Id: Ifcd121800ffe9d0cae0b7984f98cf9bf1c83f002
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this issue Dec 1, 2022
‘-webkit-text-fill-color’ is valid_for_highlight, but we forgot to
mark ‘-webkit-text-stroke-color’ and ‘-webkit-text-stroke-width’ as
valid_for_highlight too. They are only valid_for_highlight_legacy
at the moment.

Whether all three should be applicable is pending a spec issue [1],
but HighlightInheritance is not stable yet anyway, and enabling them
in this patch unblocks bumping HighlightInheritance to experimental.

[1] w3c/csswg-drafts#7580

Bug: 1024156
Change-Id: Ifcd121800ffe9d0cae0b7984f98cf9bf1c83f002
aarongable pushed a commit to chromium/chromium that referenced this issue Dec 1, 2022
‘-webkit-text-fill-color’ is valid_for_highlight, but we forgot to
mark ‘-webkit-text-stroke-color’ and ‘-webkit-text-stroke-width’ as
valid_for_highlight too. They are only valid_for_highlight_legacy
at the moment.

Whether all three should be applicable is pending a spec issue [1],
but HighlightInheritance is not stable yet anyway, and enabling them
in this patch unblocks bumping HighlightInheritance to experimental.

[1] w3c/csswg-drafts#7580

Bug: 1024156
Change-Id: Ifcd121800ffe9d0cae0b7984f98cf9bf1c83f002
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4060396
Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org>
Commit-Queue: Delan Azabani <dazabani@igalia.com>
Cr-Commit-Position: refs/heads/main@{#1078054}
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this issue Dec 1, 2022
‘-webkit-text-fill-color’ is valid_for_highlight, but we forgot to
mark ‘-webkit-text-stroke-color’ and ‘-webkit-text-stroke-width’ as
valid_for_highlight too. They are only valid_for_highlight_legacy
at the moment.

Whether all three should be applicable is pending a spec issue [1],
but HighlightInheritance is not stable yet anyway, and enabling them
in this patch unblocks bumping HighlightInheritance to experimental.

[1] w3c/csswg-drafts#7580

Bug: 1024156
Change-Id: Ifcd121800ffe9d0cae0b7984f98cf9bf1c83f002
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4060396
Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org>
Commit-Queue: Delan Azabani <dazabani@igalia.com>
Cr-Commit-Position: refs/heads/main@{#1078054}
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this issue Dec 1, 2022
‘-webkit-text-fill-color’ is valid_for_highlight, but we forgot to
mark ‘-webkit-text-stroke-color’ and ‘-webkit-text-stroke-width’ as
valid_for_highlight too. They are only valid_for_highlight_legacy
at the moment.

Whether all three should be applicable is pending a spec issue [1],
but HighlightInheritance is not stable yet anyway, and enabling them
in this patch unblocks bumping HighlightInheritance to experimental.

[1] w3c/csswg-drafts#7580

Bug: 1024156
Change-Id: Ifcd121800ffe9d0cae0b7984f98cf9bf1c83f002
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4060396
Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org>
Commit-Queue: Delan Azabani <dazabani@igalia.com>
Cr-Commit-Position: refs/heads/main@{#1078054}
marcoscaceres pushed a commit to web-platform-tests/wpt that referenced this issue Dec 1, 2022
‘-webkit-text-fill-color’ is valid_for_highlight, but we forgot to
mark ‘-webkit-text-stroke-color’ and ‘-webkit-text-stroke-width’ as
valid_for_highlight too. They are only valid_for_highlight_legacy
at the moment.

Whether all three should be applicable is pending a spec issue [1],
but HighlightInheritance is not stable yet anyway, and enabling them
in this patch unblocks bumping HighlightInheritance to experimental.

[1] w3c/csswg-drafts#7580

Bug: 1024156
Change-Id: Ifcd121800ffe9d0cae0b7984f98cf9bf1c83f002
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4060396
Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org>
Commit-Queue: Delan Azabani <dazabani@igalia.com>
Cr-Commit-Position: refs/heads/main@{#1078054}
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this issue Dec 11, 2022
…erties valid_for_highlight, a=testonly

Automatic update from web-platform-tests
HighlightInheritance: compat stroke properties valid_for_highlight

‘-webkit-text-fill-color’ is valid_for_highlight, but we forgot to
mark ‘-webkit-text-stroke-color’ and ‘-webkit-text-stroke-width’ as
valid_for_highlight too. They are only valid_for_highlight_legacy
at the moment.

Whether all three should be applicable is pending a spec issue [1],
but HighlightInheritance is not stable yet anyway, and enabling them
in this patch unblocks bumping HighlightInheritance to experimental.

[1] w3c/csswg-drafts#7580

Bug: 1024156
Change-Id: Ifcd121800ffe9d0cae0b7984f98cf9bf1c83f002
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4060396
Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org>
Commit-Queue: Delan Azabani <dazabani@igalia.com>
Cr-Commit-Position: refs/heads/main@{#1078054}

--

wpt-commits: 204eae05514325f7949f48638237da3eb03c19b1
wpt-pr: 37270
BruceDai pushed a commit to BruceDai/wpt that referenced this issue Dec 13, 2022
‘-webkit-text-fill-color’ is valid_for_highlight, but we forgot to
mark ‘-webkit-text-stroke-color’ and ‘-webkit-text-stroke-width’ as
valid_for_highlight too. They are only valid_for_highlight_legacy
at the moment.

Whether all three should be applicable is pending a spec issue [1],
but HighlightInheritance is not stable yet anyway, and enabling them
in this patch unblocks bumping HighlightInheritance to experimental.

[1] w3c/csswg-drafts#7580

Bug: 1024156
Change-Id: Ifcd121800ffe9d0cae0b7984f98cf9bf1c83f002
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4060396
Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org>
Commit-Queue: Delan Azabani <dazabani@igalia.com>
Cr-Commit-Position: refs/heads/main@{#1078054}
jamienicol pushed a commit to jamienicol/gecko that referenced this issue Dec 14, 2022
…erties valid_for_highlight, a=testonly

Automatic update from web-platform-tests
HighlightInheritance: compat stroke properties valid_for_highlight

‘-webkit-text-fill-color’ is valid_for_highlight, but we forgot to
mark ‘-webkit-text-stroke-color’ and ‘-webkit-text-stroke-width’ as
valid_for_highlight too. They are only valid_for_highlight_legacy
at the moment.

Whether all three should be applicable is pending a spec issue [1],
but HighlightInheritance is not stable yet anyway, and enabling them
in this patch unblocks bumping HighlightInheritance to experimental.

[1] w3c/csswg-drafts#7580

Bug: 1024156
Change-Id: Ifcd121800ffe9d0cae0b7984f98cf9bf1c83f002
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4060396
Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org>
Commit-Queue: Delan Azabani <dazabani@igalia.com>
Cr-Commit-Position: refs/heads/main@{#1078054}

--

wpt-commits: 204eae05514325f7949f48638237da3eb03c19b1
wpt-pr: 37270
@fantasai fantasai added this to Wednesday in Cupertino F2F Agenda Jul 18, 2023
@css-meeting-bot
Copy link
Member

The CSS Working Group just discussed [css-pseudo] highlight pseudos and compat stroke/fill properties, and agreed to the following:

  • RESOLVED: Do not support them until unprefixed
The full IRC log of that discussion <emilio> schenney: Simple question: -webkit- prefixed stroke / fill properties are interoperable and supported across browsers, but not supported in highlights
<emilio> ... question is should they?
<bramus> emilio: I think they are not synonymous with their unprefixed versions. some are not impl as aliases
<schenney> q+
<bramus> emilio: I think it is worth trying not to support them
<TabAtkins> agree
<Rossen_> ack fantasai
<emilio> fantasai: I think the intention was that they would eventually be synonymous
<emilio> ... we should look into whether we can make them aliases
<florian> q+
<emilio> ... up until we do that I'm fine with them not being supported
<emilio> ack schenney
<GameMaker> q+
<emilio> schenney: I'd support not supporting them but could in the future if appropriate
<emilio> ack florian
<Rossen_> ack florian
<fantasai> s/if appropriate/if unprefixing them becomes appropriate/
<emilio> florian: the compat spec isn't entirely clear between the interaction between these and the unprefixed versions
<emilio> ... we should be looking into doing this
<emilio> ... and if they end up being aliases then yeah they should work
<emilio> fantasai: makes sense, I guess that means TabAtkins and I are responsible for that
<emilio> ... if/when we can make them aliases then they'd start working
<emilio> ack GameMaker
<Rossen_> ack GameMaker
<emilio> GameMaker: I'm agreeing with fantasai, support them once unprefixed, not support them until then
<TabAtkins> (elika and I stopped working on fill-stroke because there was no one biting on implementation)
<TabAtkins> (we're happy to pick it up again)
<emilio> RESOLVED: Do not support them until unprefixed
<GameMaker> WebKit obviously has an implementation, and we were just looking at supporting these in highlights, so I would love if we can move forward with the unprefixed versions

@fantasai
Copy link
Collaborator

This needs a clarifying note.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

No branches or pull requests

5 participants