Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[css-animations-2][web-animations-2] API For specifying phase linked offsets in keyframes #7637

Closed
flackr opened this issue Aug 23, 2022 · 1 comment

Comments

@flackr
Copy link
Contributor

flackr commented Aug 23, 2022

In #7044 we resolved to add phase linked offsets to the animations APIs. We discussed a simple CSS syntax such as the following:

@keyframes fade-in-out-animation {
  enter 0% { opacity: 0; }
  enter 100% { opacity: 1; }
  exit 0% { opacity: 1; }
  exit 100% { opacity: 0; }
}

We didn't talk about a syntax for the web-animations API, however #7589 touches on an API for the similar delay and endDelay properties so we should probably do the same here. Concretely this means whichever format we choose for #7589 (i.e. String or Object), that could be specified for offset in the Keyframe dictionary and should likely be returned by getKeyframes.

@css-meeting-bot
Copy link
Member

The CSS Working Group just discussed API for phase-linked offsets in keyframes, and agreed to the following:

  • RESOLVED: Use same object as in 7589 to specify keyframe offsets as well
The full IRC log of that discussion <TabAtkins> Topic: API for phase-linked offsets in keyframes
<TabAtkins> github: https://github.com//issues/7637
<TabAtkins> flackr: Related to previous, we also resolved in CSS that you could link keyframes to timeline phases
<TabAtkins> flackr: But again we didn't have a JS way to do it
<TabAtkins> flackr: So the issue suggests that we reuse the previous resolution's format for specifying keyframe offsets
<TabAtkins> +1
<TabAtkins> flackr: So represetning a keyframe position as phase+offset
<TabAtkins> Rossen_: objections?
<bramus> +1
<Sebo> +1
<TabAtkins> flackr: Summarized: support passing a phase+offset object in the keyframe offsets
<TabAtkins> RESOLVED: Use same object as in 7589 to specify keyframe offsets as well

@bramus bramus moved this from High priority to Needs Edits in Scroll linked animations [scroll-animations] Feb 2, 2023
fantasai added a commit to fantasai/csswg-drafts that referenced this issue Mar 24, 2023
fantasai added a commit to fantasai/csswg-drafts that referenced this issue Mar 27, 2023
@flackr flackr moved this from Needs Edits to In Review in Scroll linked animations [scroll-animations] Mar 28, 2023
fantasai added a commit to fantasai/csswg-drafts that referenced this issue Mar 29, 2023
fantasai added a commit to fantasai/csswg-drafts that referenced this issue Apr 1, 2023
fantasai added a commit to fantasai/csswg-drafts that referenced this issue Apr 3, 2023
@fantasai fantasai added Commenter Satisfied Commenter has indicated satisfaction with the resolution / edits. and removed Needs Review of Proposed Text labels Apr 4, 2023
@fantasai fantasai closed this as completed Apr 4, 2023
Scroll linked animations [scroll-animations] automation moved this from In Review to Done Apr 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Closed Accepted by CSSWG Resolution Commenter Satisfied Commenter has indicated satisfaction with the resolution / edits. css-animations-2 scroll-animations-1 Current Work web-animations-2 Current Work
Development

No branches or pull requests

3 participants