-
Notifications
You must be signed in to change notification settings - Fork 642
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[css-nesting] Inserting new sub-rules with .style #7933
Comments
Cf. w3c/csswg-drafts#7933. Change-Id: Id0327f0188f6edd3faeda92aafd06b5f5c518fe4
Cf. w3c/csswg-drafts#7933. Change-Id: Id0327f0188f6edd3faeda92aafd06b5f5c518fe4
Cf. w3c/csswg-drafts#7933. Change-Id: Id0327f0188f6edd3faeda92aafd06b5f5c518fe4
Setting |
Cf. w3c/csswg-drafts#7933. Change-Id: Id0327f0188f6edd3faeda92aafd06b5f5c518fe4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3970663 Commit-Queue: Steinar H Gunderson <sesse@chromium.org> Reviewed-by: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/main@{#1062164}
Cf. w3c/csswg-drafts#7933. Change-Id: Id0327f0188f6edd3faeda92aafd06b5f5c518fe4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3970663 Commit-Queue: Steinar H Gunderson <sesse@chromium.org> Reviewed-by: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/main@{#1062164}
Cf. w3c/csswg-drafts#7933. Change-Id: Id0327f0188f6edd3faeda92aafd06b5f5c518fe4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3970663 Commit-Queue: Steinar H Gunderson <sesse@chromium.org> Reviewed-by: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/main@{#1062164}
That would be 5. But 5 is inconsistent with current behavior for e.g. |
If a This seems a good argument for @FremyCompany's proposal that keeps each thing separate. |
Or a good argument to hang this off of |
I hate to repeat myself, but we are unlikely to implement this, at least in a form that is not strongly restricted. (I cannot speak for Gecko and WebKit, but both have already signaled worries about CSSOM complexity as I understand it, so increasing it further might not be the best course of action.) |
Given that many things that were previously hard to implement are currently being implemented, I'd be wary of choosing a CSSOM design that excludes this possibility. That would mean that once we do have nested inline styles, we'd end up with an inconsistent CSSOM. |
It already is inconsistent in exactly this fashion. Reading .cssText includes conditional group rules (such as |
Can |
No, you're right. But if you take e.g. a |
…e., a=testonly Automatic update from web-platform-tests [css-nesting] Add a CSSOM test for .style. Cf. w3c/csswg-drafts#7933. Change-Id: Id0327f0188f6edd3faeda92aafd06b5f5c518fe4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3970663 Commit-Queue: Steinar H Gunderson <sesse@chromium.org> Reviewed-by: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/main@{#1062164} -- wpt-commits: 38ddcd38f6da0171075e02792c777485f6d51319 wpt-pr: 36587
…e., a=testonly Automatic update from web-platform-tests [css-nesting] Add a CSSOM test for .style. Cf. w3c/csswg-drafts#7933. Change-Id: Id0327f0188f6edd3faeda92aafd06b5f5c518fe4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3970663 Commit-Queue: Steinar H Gunderson <sesse@chromium.org> Reviewed-by: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/main@{#1062164} -- wpt-commits: 38ddcd38f6da0171075e02792c777485f6d51319 wpt-pr: 36587
During test writing, this came to mind:
What should happen?
I'd say the sane thing to do is 2 since we parse a list of declarations (and already ignore
@media
etc. when setting .style), but this needs to be explicit in the spec, I think.The text was updated successfully, but these errors were encountered: