-
Notifications
You must be signed in to change notification settings - Fork 637
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[css-color-4] Incorrect description on preprocessing hue angles for interpolation #8838
Comments
@LeaVerou could you look into this please? |
@LeaVerou I suspect that should be (my emphasis)
and
which, in the example above, would give 400 - 360 = 40 |
@svgeesus Two small issues regarding 2641c47:
|
Yes, intentional. We actually decided that a while ago (when we changed HSL to allow round-tripping of out of gamut colors) and I noticed that I had not updated the spec there. Thanks! Will update the pseudo-codes asap. |
@svgeesus Sorry to bother again 🙏, but is csswg-drafts/css-color-4/Overview.bs Lines 971 to 981 in 0645f1b
csswg-drafts/css-color-4/Overview.bs Lines 6653 to 6659 in 0645f1b
|
Well spotted, agreed and fixed for the first one. Te second is in a change log so it stays (but there will be another entry in the changes, when I add recent changes, about this). |
The Hue Interpolation section says:
However, the angle pair
(θ1, θ2) = (40deg, 400deg)
passes the preprocessing steps without being modified, leaving withθ2 > 360deg
.Based on the four algorithms described in this section, it seems that only the lesser of the two angles needs to be in
[0deg, 360deg)
(and the difference be in[0deg, 360deg]
). However, this implies that the greater angle can be outside[0deg, 360deg]
, which contradicts Section 4.3:The text was updated successfully, but these errors were encountered: