Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[css-ui-4] influence of outline-width on auto style outlines #9201

Closed
frivoal opened this issue Aug 16, 2023 · 8 comments
Closed

[css-ui-4] influence of outline-width on auto style outlines #9201

frivoal opened this issue Aug 16, 2023 · 8 comments
Labels
Closed Accepted by CSSWG Resolution css-ui-4 Current Work Tested Memory aid - issue has WPT tests

Comments

@frivoal
Copy link
Collaborator

frivoal commented Aug 16, 2023

CSS-UI claims that it's up to user agents to determine whether and how outline-width influences the rendering of outlines with outline-style auto.

However, this is problematic, for the similar reasons as discussed about color in #7761:

outline: auto sets outline-style to auto and outline-width to medium, and medium means 3px.

The default UA sheet in the HTML spec has :focus-visible { outline: auto; }, and so, in browsers that want to take outline-width into account, it effectively calls for the default rendering of focus outlines to be native outlines somehow tweaked to be 3px wide. That seems unfortunate.

I think we should either:

  • remove the claim that outline-width is allowed to influence the rendering of auto style outlines.
  • similarly to what we did in [css-ui] Tweaking outline-style: auto colors. #7761, allow outline-width to influence the rendering of auto style outlines, but to make that work sensibly, add an auto initial value to outline-width which computes to medium when outline-style is anything but auto, but lets auto style outlines render at their natural size unless the author has explicitly called for something else.
@frivoal frivoal added the css-ui-4 Current Work label Aug 16, 2023
@Loirooriol
Copy link
Contributor

Does any browser let outline-width affect the size auto outlines?

@frivoal
Copy link
Collaborator Author

frivoal commented Aug 25, 2023

As far as I know, neither Safari, Firefox, nor Chrome do it.
As far as my tests could confirm, the only print formatter which does is BFO Publisher.

@faceless2 is this something that matters to you?

@faceless2
Copy link

If it looks like it might matter to us, it's almost certainly a bug 😁 I thought we simply treated auto as solid - no impact on width at all.

@Loirooriol
Copy link
Contributor

If you treat auto as solid, then it's normal for it to be affected by outline-width. Same for Servo.

I was referring to the native outlines.

@frivoal
Copy link
Collaborator Author

frivoal commented Aug 30, 2023

Agenda+ to propose removing the claim that outline-width is allowed to influence the rendering of auto style outlines

@astearns astearns added this to Unslotted in TPAC 2023 agenda Sep 7, 2023
@css-meeting-bot
Copy link
Member

The CSS Working Group just discussed [css-ui-4] influence of outline-width on auto style outlines, and agreed to the following:

  • RESOLVED: Remove the claim that outline-width influences the rendering of auto style outlines
The full IRC log of that discussion <dael> astearns: This was florian
<dael> TabAtkins: Look straightforward
<dael> astearns: Prop: Remove the claim that outline-width influences the rendering
<dael> astearns: Obj?
<dael> astearns: Prop: Remove the claim that outline-width influences the rendering of auto-style outlines
<dael> RESOLVED: Remove the claim that outline-width influences the rendering of auto style outlines

@Loirooriol
Copy link
Contributor

Loirooriol commented Nov 7, 2023

I disagree with the test. We (Servo) do not intend to treat auto different than solid for now, and this is allowed by the spec ("User agents may treat auto as solid"). solid obeys outline-width, so we are failing the test.

Please change the test to also accept a different expectation with div { outline: solid 100px} div+div { outline: solid 0px } or such.

@frivoal
Copy link
Collaborator Author

frivoal commented Nov 8, 2023

@Loirooriol , good point. Made a follow up PR to adjust the test, review appreciated: web-platform-tests/wpt#43010

moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this issue Nov 14, 2023
…utline-style is auto, a=testonly

Automatic update from web-platform-tests
[css-ui] outline-width is ignored when outline-style is auto

See w3c/csswg-drafts#9201

--

wpt-commits: f30784e70ca6582f3d705ce309082c4271375116
wpt-pr: 42988
frivoal added a commit to web-platform-tests/wpt that referenced this issue Nov 15, 2023
vinnydiehl pushed a commit to vinnydiehl/mozilla-unified that referenced this issue Nov 15, 2023
…utline-style is auto, a=testonly

Automatic update from web-platform-tests
[css-ui] outline-width is ignored when outline-style is auto

See w3c/csswg-drafts#9201

--

wpt-commits: f30784e70ca6582f3d705ce309082c4271375116
wpt-pr: 42988
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified-and-comments-removed that referenced this issue Nov 16, 2023
…utline-style is auto, a=testonly

Automatic update from web-platform-tests
[css-ui] outline-width is ignored when outline-style is auto

See w3c/csswg-drafts#9201

--

wpt-commits: f30784e70ca6582f3d705ce309082c4271375116
wpt-pr: 42988

UltraBlame original commit: 120c6ca2e7ffbf097de267bd7183339c2d4d9f9b
gecko-dev-updater pushed a commit to marco-c/gecko-dev-comments-removed that referenced this issue Nov 16, 2023
…utline-style is auto, a=testonly

Automatic update from web-platform-tests
[css-ui] outline-width is ignored when outline-style is auto

See w3c/csswg-drafts#9201

--

wpt-commits: f30784e70ca6582f3d705ce309082c4271375116
wpt-pr: 42988

UltraBlame original commit: 120c6ca2e7ffbf097de267bd7183339c2d4d9f9b
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified that referenced this issue Nov 16, 2023
…utline-style is auto, a=testonly

Automatic update from web-platform-tests
[css-ui] outline-width is ignored when outline-style is auto

See w3c/csswg-drafts#9201

--

wpt-commits: f30784e70ca6582f3d705ce309082c4271375116
wpt-pr: 42988

UltraBlame original commit: 120c6ca2e7ffbf097de267bd7183339c2d4d9f9b
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this issue Nov 20, 2023
…utline-style is auto, a=testonly

Automatic update from web-platform-tests
[css-ui] outline-width is ignored when outline-style is auto

See w3c/csswg-drafts#9201

--

wpt-commits: f30784e70ca6582f3d705ce309082c4271375116
wpt-pr: 42988
jamienicol pushed a commit to jamienicol/gecko that referenced this issue Nov 20, 2023
…utline-style is auto, a=testonly

Automatic update from web-platform-tests
[css-ui] outline-width is ignored when outline-style is auto

See w3c/csswg-drafts#9201

--

wpt-commits: f30784e70ca6582f3d705ce309082c4271375116
wpt-pr: 42988
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified-and-comments-removed that referenced this issue Nov 21, 2023
…utline-style is auto, a=testonly

Automatic update from web-platform-tests
[css-ui] outline-width is ignored when outline-style is auto

See w3c/csswg-drafts#9201

--

wpt-commits: f30784e70ca6582f3d705ce309082c4271375116
wpt-pr: 42988

UltraBlame original commit: f372f13f23531af08c8f4786a858d2d352db8d1a
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified that referenced this issue Nov 21, 2023
…utline-style is auto, a=testonly

Automatic update from web-platform-tests
[css-ui] outline-width is ignored when outline-style is auto

See w3c/csswg-drafts#9201

--

wpt-commits: f30784e70ca6582f3d705ce309082c4271375116
wpt-pr: 42988

UltraBlame original commit: f372f13f23531af08c8f4786a858d2d352db8d1a
gecko-dev-updater pushed a commit to marco-c/gecko-dev-comments-removed that referenced this issue Nov 21, 2023
…utline-style is auto, a=testonly

Automatic update from web-platform-tests
[css-ui] outline-width is ignored when outline-style is auto

See w3c/csswg-drafts#9201

--

wpt-commits: f30784e70ca6582f3d705ce309082c4271375116
wpt-pr: 42988

UltraBlame original commit: f372f13f23531af08c8f4786a858d2d352db8d1a
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this issue Nov 22, 2023
…process the same as solid, a=testonly

Automatic update from web-platform-tests
[css-ui] Allow outline-style:auto to be process the same as solid (#43010)

In response to w3c/csswg-drafts#9201 (comment)

Co-authored-by: Oriol Brufau <obrufau@igalia.com>
--

wpt-commits: 9d3be8a51be474e3fd9a6b96d2432df1ef22f333
wpt-pr: 43010
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this issue Nov 22, 2023
…process the same as solid, a=testonly

Automatic update from web-platform-tests
[css-ui] Allow outline-style:auto to be process the same as solid (#43010)

In response to w3c/csswg-drafts#9201 (comment)

Co-authored-by: Oriol Brufau <obrufau@igalia.com>
--

wpt-commits: 9d3be8a51be474e3fd9a6b96d2432df1ef22f333
wpt-pr: 43010
vinnydiehl pushed a commit to vinnydiehl/mozilla-unified that referenced this issue Nov 24, 2023
…process the same as solid, a=testonly

Automatic update from web-platform-tests
[css-ui] Allow outline-style:auto to be process the same as solid (#43010)

In response to w3c/csswg-drafts#9201 (comment)

Co-authored-by: Oriol Brufau <obrufau@igalia.com>
--

wpt-commits: 9d3be8a51be474e3fd9a6b96d2432df1ef22f333
wpt-pr: 43010
vinnydiehl pushed a commit to vinnydiehl/mozilla-unified that referenced this issue Nov 24, 2023
…process the same as solid, a=testonly

Automatic update from web-platform-tests
[css-ui] Allow outline-style:auto to be process the same as solid (#43010)

In response to w3c/csswg-drafts#9201 (comment)

Co-authored-by: Oriol Brufau <obrufau@igalia.com>
--

wpt-commits: 9d3be8a51be474e3fd9a6b96d2432df1ef22f333
wpt-pr: 43010
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified-and-comments-removed that referenced this issue Nov 30, 2023
…process the same as solid, a=testonly

Automatic update from web-platform-tests
[css-ui] Allow outline-style:auto to be process the same as solid (#43010)

In response to w3c/csswg-drafts#9201 (comment)

Co-authored-by: Oriol Brufau <obrufauigalia.com>
--

wpt-commits: 9d3be8a51be474e3fd9a6b96d2432df1ef22f333
wpt-pr: 43010

UltraBlame original commit: 999a7f8fde7054212a2068566d155b118a35f828
gecko-dev-updater pushed a commit to marco-c/gecko-dev-comments-removed that referenced this issue Nov 30, 2023
…process the same as solid, a=testonly

Automatic update from web-platform-tests
[css-ui] Allow outline-style:auto to be process the same as solid (#43010)

In response to w3c/csswg-drafts#9201 (comment)

Co-authored-by: Oriol Brufau <obrufauigalia.com>
--

wpt-commits: 9d3be8a51be474e3fd9a6b96d2432df1ef22f333
wpt-pr: 43010

UltraBlame original commit: 999a7f8fde7054212a2068566d155b118a35f828
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified that referenced this issue Nov 30, 2023
…process the same as solid, a=testonly

Automatic update from web-platform-tests
[css-ui] Allow outline-style:auto to be process the same as solid (#43010)

In response to w3c/csswg-drafts#9201 (comment)

Co-authored-by: Oriol Brufau <obrufauigalia.com>
--

wpt-commits: 9d3be8a51be474e3fd9a6b96d2432df1ef22f333
wpt-pr: 43010

UltraBlame original commit: 999a7f8fde7054212a2068566d155b118a35f828
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Closed Accepted by CSSWG Resolution css-ui-4 Current Work Tested Memory aid - issue has WPT tests
Projects
Development

No branches or pull requests

5 participants