Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[css-selectors-4] The column combinator is not a combinator #9544

Closed
InSyncWithFoo opened this issue Nov 1, 2023 · 7 comments
Closed

[css-selectors-4] The column combinator is not a combinator #9544

InSyncWithFoo opened this issue Nov 1, 2023 · 7 comments

Comments

@InSyncWithFoo
Copy link

According to the grammar and its name, it is one:

<combinator> = '>' | '+' | '~' | [ '|' '|' ]

Yet § 3.1. Structure and Terminology says it's not:

A combinator is a condition of relationship between two elements represented by the compound selectors on either side. Combinators in Selectors Level 4 include: the descendant combinator (white space), the child combinator (U+003E, >), the next-sibling combinator (U+002B, +), and the subsequent-sibling combinator (U+007E, ~).

Am I missing something?

@andruud
Copy link
Member

andruud commented Nov 1, 2023

Huh. Is it an editing mistake?

@tabatkins
Copy link
Member

It got left in the grammar, yeah.

@cdoublev
Copy link
Collaborator

cdoublev commented Nov 23, 2023

I do not understand the change. How col || td (as in 16.1. Column combinator (||)) is supposed to match <complex-selector> now that '|' '|' is removed from <combinator>?

Maybe it could have just been listed in section 3.1. Otherwise, this is no longer required in 18. Grammar:

White space is forbidden: [...] Between the components of a <combinator>.

@Loirooriol Loirooriol reopened this Nov 23, 2023
@bramus
Copy link
Contributor

bramus commented Jan 22, 2024

I do not understand the change. How col || td (as in 16.1. Column combinator (||)) is supposed to match <complex-selector> now that '|' '|' is removed from <combinator>?

Yeah, also not following here. Or is the plan to remove the column combinator from selectors-4?

@tabatkins
Copy link
Member

Clearly I'd just made a second mistake, in not realizing that the column combinator was still listed as a feature in the spec. (The utter lack of implementor interest in the years since it was added likely caused me to misremember it as already having been removed.) I'll put it back for now.

@InSyncWithFoo
Copy link
Author

InSyncWithFoo commented Jan 23, 2024

@tabatkins What about Section 3.1? How is this any different from what we had when I opened this issue?

@tabatkins
Copy link
Member

It's not. Tho technically it's still correct: the selectors do include those listed ones, there's just more than what's listed. ^_^

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants