Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[css-view-transitions-2] Allow empty :active-view-transition() ? #9626

Closed
fantasai opened this issue Nov 22, 2023 · 3 comments · Fixed by #10072
Closed

[css-view-transitions-2] Allow empty :active-view-transition() ? #9626

fantasai opened this issue Nov 22, 2023 · 3 comments · Fixed by #10072
Labels
css-view-transitions-2 View Transitions; New feature requests

Comments

@fantasai
Copy link
Collaborator

In general, if there's reasonable default behavior, we allow omitting arguments, so... should :active-view-transition() be equivalent to :active-view-transition(*)?
@fantasai fantasai added the css-view-transitions-2 View Transitions; New feature requests label Nov 22, 2023
@noamr noamr mentioned this issue Nov 23, 2023
Closed
@ydaniv
Copy link
Contributor

ydaniv commented Nov 23, 2023

Basically with empty params it reads as a transition with zero types, unlike * which reads as any types. I guess there's a difference. It could be used as selecting the default transition with zero specified types, if that makes sense.

@nt1m
Copy link
Member

nt1m commented Nov 26, 2023

I would prefer allowing :active-view-transition over :active-view-transition() (as an alias to :active-view-transition(*)). The former reads "There is an active view transition" whereas the latter reads as "There is an active view transition with empty arguments". So the former makes more sense as a short syntax for :active-view-transition(*)

@vmpstr vmpstr mentioned this issue Jan 29, 2024
Closed
@css-meeting-bot css-meeting-bot mentioned this issue Mar 13, 2024
Closed
noamr added a commit to noamr/csswg-drafts that referenced this issue Mar 13, 2024
@noamr
[css-view-transitions-2] Apply resolutions for view-transition types
19f0a78 
- Make types mutable using ViewTransition.typeList
w3c#9542 (comment)

- Separate `:active-view-transition` and `:active-view-transition-type`
See w3c#9972 (comment)

- Add notes about types being bound to one document
See w3c#9526 (comment)

Closes w3c#9972
Closes w3c#9542
Closes w3c#9526
Closes w3c#9626
@noamr noamr mentioned this issue Mar 13, 2024
Merged
@astearns
Copy link
Member

We resolved in #9972 (comment) to have two versions, one which omits arguments and one that must take a type argument

noamr added a commit that referenced this issue Mar 14, 2024
@noamr @khushalsagar
[css-view-transitions-2] Apply resolutions for view-transition types (#…
bd11f28 
…10072)

* [css-view-transitions-2] Apply resolutions for view-transition types

- Make types mutable using ViewTransition.typeList
#9542 (comment)

- Separate `:active-view-transition` and `:active-view-transition-type`
See #9972 (comment)

- Add notes about types being bound to one document
See #9526 (comment)

Closes #9972
Closes #9542
Closes #9526
Closes #9626

Co-authored-by: Khushal Sagar <63884798+khushalsagar@users.noreply.github.com>

---------

Co-authored-by: Khushal Sagar <63884798+khushalsagar@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
css-view-transitions-2 View Transitions; New feature requests
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[css-view-transitions-2] Apply resolutions for view-transition types noamr/csswg-drafts
4 participants
@ydaniv @fantasai @astearns @nt1m