Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[css-view-transitions-2] Update non-normative notes once pageconceal or so is upstreamed #9886

Closed
noamr opened this issue Feb 1, 2024 · 9 comments
Closed

[css-view-transitions-2] Update non-normative notes once pageconceal or so is upstreamed #9886

noamr opened this issue Feb 1, 2024 · 9 comments
Assignees
@noamr
Labels
css-view-transitions-2 View Transitions; New feature requests

Comments

@noamr
Copy link
Collaborator

noamr commented Feb 1, 2024

No description provided.

@noamr noamr self-assigned this Feb 1, 2024
@khushalsagar
Copy link
Member

This text could also reference explicit pageconceal and pagereveal events: https://drafts.csswg.org/css-view-transitions-2/#:~:text=(when%20unloading)%20and%20in%20the%20new%20document%20(when%20reveal).

@khushalsagar
Copy link
Member

remove https://drafts.csswg.org/css-view-transitions-2/#:~:text=boolean%2C%20initially%20false.-,should%20a%20cross%2Ddocument%20transition%20take%20precedent%3F%20See%20%239512,-active%20types

@khushalsagar
Copy link
Member

Add a non-normative note for algorithms invoked by the html spec. For example: https://drafts.csswg.org/css-view-transitions-2/#resolve-view-transition-rule-algo

@khushalsagar
Copy link
Member

This should be in L2: https://drafts.csswg.org/css-view-transitions-2/#resolve-view-transition-rule-algo:~:text=Set%20oldDocument%E2%80%99s%20auto%2Dskip%20view%20transitions%20to%20true.

@khushalsagar
Copy link
Member

Move this to L2: https://drafts.csswg.org/css-view-transitions-1/#viewtransition-process-old-state-captured

@khushalsagar
Copy link
Member

khushalsagar commented Feb 1, 2024 •
edited

"Call onReady" should be the last step of https://drafts.csswg.org/css-view-transitions-2/#setup-cross-document-view-transition

Also rename onReady to something clearer.

@khushalsagar khushalsagar mentioned this issue Feb 1, 2024
Open
noamr added a commit to noamr/csswg-drafts that referenced this issue Feb 2, 2024
@noamr
Move onReady to the correct place and rename
5c5633f 
See w3c#9886 (comment)
@noamr noamr mentioned this issue Feb 2, 2024
Merged
@fantasai fantasai added the css-view-transitions-2 View Transitions; New feature requests label Feb 5, 2024
@fantasai
Copy link
Collaborator

fantasai commented Feb 5, 2024

(p.s. @noamr please do me a favor and label your issues :)

@noamr
Copy link
Collaborator Author

noamr commented Feb 6, 2024

(p.s. @noamr please do me a favor and label your issues :)

Ack

noamr added a commit to noamr/csswg-drafts that referenced this issue Feb 9, 2024
@noamr
Move onReady to the correct place and rename
a423828 
See w3c#9886 (comment)
noamr added a commit to noamr/csswg-drafts that referenced this issue Feb 13, 2024
@noamr
Move onReady to the correct place and rename
4d40d9b 
See w3c#9886 (comment)
noamr added a commit that referenced this issue Feb 13, 2024
@noamr @khushalsagar
[css-view-transitions-2] Editorial: refactor L2 concerns out of L1 (#…
6b3259f 
…9892)

* Move `onReady` to the correct place and rename

See #9886 (comment)

* Call proceed with navigation after capturing old doc

* Move all cross-doc references to L2

* Update css-view-transitions-2/Overview.bs

Co-authored-by: Khushal Sagar <63884798+khushalsagar@users.noreply.github.com>

* Restructure new document steps and auto-skip

* Add missing piece

* Remove more references to L2

* Address PR nits

* Address PR nits

* Address PR nits

* nits

* Add rendering suppression

* Move skip steps to monkey patch

---------

Co-authored-by: Khushal Sagar <63884798+khushalsagar@users.noreply.github.com>
@noamr noamr closed this as completed Feb 14, 2024
@noamr
Copy link
Collaborator Author

noamr commented Feb 14, 2024

I believe all of this is addressed now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@noamr noamr

Labels
css-view-transitions-2 View Transitions; New feature requests
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@noamr @fantasai @khushalsagar