Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[css-fonts-4] linkable definition of palette-mix() function (not <palette-mix()> type) #9969

Closed
foolip opened this issue Feb 16, 2024 · 3 comments · Fixed by #9976
Closed

[css-fonts-4] linkable definition of palette-mix() function (not <palette-mix()> type) #9969

foolip opened this issue Feb 16, 2024 · 3 comments · Fixed by #9976
Assignees
@svgeesus
Labels
Closed Accepted as Obvious Bugfix css-fonts-4 Current Work

Comments

@foolip
Copy link
Member

foolip commented Feb 16, 2024

<palette-mix()> with angle brackets around it is used in the definition of font-palette's value, and I take the angle brackets and URL to mean it's a type, no the palette-mix() function itself.

I would like there to be a linkable definition of the function, similar to for color-mix():
https://drafts.csswg.org/css-fonts-4/#funcdef-palette-mix (does not exist)
https://drafts.csswg.org/css-color-5/#funcdef-color-mix (exists)

I suspect that it did work in @drott's #9282, but @cdoublev's #9381 removed it as duplicate. To avoid flipping back and forth, I'm filing an issue instead of sending a PR.
foolip added a commit to mdn/browser-compat-data that referenced this issue Feb 16, 2024
@foolip
Add palette-mix() function as subfeature of font-palette
c1157bd 
This entry effectively represents the ability to animate font-palette.
The Chrome version is from this chromestatus entry:
https://chromestatus.com/feature/5177171439517696

BCD currently represents functions both under css.types and under
specific properties that accept those functions are values.

Since palette-mix() can so far only be used for font-palette, put it
there.

The spec URL is not ideal:
w3c/csswg-drafts#9969
@foolip foolip mentioned this issue Feb 16, 2024
Merged
@cdoublev
Copy link
Collaborator

cdoublev commented Feb 16, 2024 •
edited

I think palette-mix() should be defined (wrapped in <dfn>) here.

This is the function definition pattern I think we should be aiming for:

The <dfn>foo()</dfn> function blah bla.

<pre class=prod>
  <<foo()>> = foo( ... )
</pre>

#2921 (comment)

@cdoublev cdoublev added the css-fonts-4 Current Work label Feb 16, 2024
@svgeesus
Copy link
Contributor

I agree with @foolip that we should have a linkable definition. @cdoublev would you like to make a PR to define it?

ddbeck pushed a commit to mdn/browser-compat-data that referenced this issue Feb 18, 2024
@foolip
Add palette-mix() function as subfeature of font-palette (#22242)
a8ee2ad 
This entry effectively represents the ability to animate font-palette.
The Chrome version is from this chromestatus entry:
https://chromestatus.com/feature/5177171439517696

BCD currently represents functions both under css.types and under
specific properties that accept those functions are values.

Since palette-mix() can so far only be used for font-palette, put it
there.

The spec URL is not ideal:
w3c/csswg-drafts#9969
cdoublev added a commit to cdoublev/csswg-drafts that referenced this issue Feb 19, 2024
@cdoublev
[css-fonts-4] Fix markup w3c#9969
4710292
@cdoublev cdoublev mentioned this issue Feb 19, 2024
Merged
@cdoublev
Copy link
Collaborator

Yes, sure. #9976

svgeesus pushed a commit that referenced this issue Feb 20, 2024
@cdoublev @svgeesus
[css-fonts-4] Fix markup #9969
888fd1c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@svgeesus svgeesus

Labels
Closed Accepted as Obvious Bugfix css-fonts-4 Current Work
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[css-fonts-4] Fix markup #9969 cdoublev/csswg-drafts
3 participants
@foolip @svgeesus @cdoublev