New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[css-animations-2] Specify the animation-trigger property #10128
base: main
Are you sure you want to change the base?
Changes from 5 commits
133f6e0
f3a49ba
cbd4f07
9f6464a
912426a
9ae1a13
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -98,7 +98,7 @@ Repository: w3c/csswg-drafts | |
Test Suite: https://github.com/web-platform-tests/wpt/tree/master/web-animations | ||
|
||
Ignored Terms: double, boolean, unsigned long, unrestricted double, (unrestricted double or DOMString) | ||
Ignored Vars: did seek, synchronously notify, auto-rewind | ||
Ignored Vars: did seek, synchronously notify, auto-rewind, did trigger | ||
Markup Shorthands: markdown yes | ||
Include Mdn Panels: no | ||
</pre> | ||
|
@@ -772,6 +772,9 @@ Animation Frames {#animation-frame-loop} | |
* Updating the [=animation/current time=] of any [=animations=] | ||
[=associated with a timeline|associated with=] the timeline. | ||
|
||
* Updating the [=animation trigger state=] of any [=animation trigger=] | ||
[=associated with a timeline|associated with=] the timeline. | ||
|
||
* Running the [=update an animation's finished state=] procedure | ||
for any animations whose [=animation/current time=] has been updated. | ||
|
||
|
@@ -3537,6 +3540,141 @@ Calculating progress {#core-animation-effect-calculations} | |
The final output <dfn>iteration progress</dfn> of an [=animation effect=] | ||
is simply its [=transformed progress=]. | ||
|
||
Animation Triggers {#triggers} | ||
----------------- | ||
|
||
### Overview ### {#triggers-overview} | ||
|
||
An <dfn export>animation trigger</dfn> is used to control the playback | ||
of its associated [=animation=] for time-driven animations. | ||
Like animations, [=animation triggers=] are associated with a [=timeline=] | ||
and are attached to an [=animation attachment range|attachment range=]. | ||
|
||
Issue: Should there be any effect of triggers on scroll-driven animations? | ||
|
||
### Animation Trigger State ### {#trigger-state} | ||
|
||
An [=animation trigger=] |trigger| with [=animation trigger type=] |type| | ||
has an internal <dfn export lt="animation trigger state">state</dfn> that can be one of the following: | ||
|
||
<dl dfn-for="animation trigger state" dfn-type=value> | ||
<dt><dfn>idle</dfn> | ||
<dd> | ||
The [=animation effect=] associated with |trigger| remains in | ||
its [=animation effect/before phase=] and stays at zero [=animation/start time=]. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I still don't quite get the hierarchy here. This suggests an animation effect is associated with a trigger but previous we said a trigger is associated with an animation. Which is it? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Right, the relation here should be indirect via the animation. The trigger is associated to the animation. The required behavior of the animation is to "hold its effect in a 'just before playing' state". I'll try to fix that. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Done, I think it's better now. |
||
|
||
<dt><dfn>primary</dfn> | ||
<dd> | ||
The ''primary'' effect defined by |type| is applied to its associated [=animation=]. | ||
|
||
<dt><dfn>inverse</dfn> | ||
<dd> | ||
The ''inverse'' effect defined by |type| is applied to its associated [=animation=]. | ||
|
||
</dl> | ||
|
||
Issue: Do we need a formal resolution on the spec of the idle state? | ||
|
||
The [=animation trigger state=] |state| of an [=animation trigger=] |trigger| | ||
is controlled by the [=animation attachment range|attachment range=] it is attached to, | ||
given a flag |did trigger|, as follows: | ||
|
||
<dl class=switch> | ||
: If |trigger|’s [=local time=] is [=unresolved=], | ||
:: | ||
Then |state| is ''animation trigger state/idle'', and |did trigger| is set to false. | ||
|
||
: Otherwise, | ||
:: | ||
|
||
<dl class=switch> | ||
: If |trigger| is inside its [=active interval=], | ||
:: | ||
Then |state| is ''animation trigger state/primary'', and |did trigger| is set to true. | ||
|
||
: Otherwise, | ||
:: | ||
|
||
<dl class=switch> | ||
: If |did trigger| flag is false, | ||
:: | ||
Then |state| is ''animation trigger state/idle''. | ||
|
||
: Otherwise, | ||
:: | ||
|state| is ''animation trigger state/inverse''. | ||
|
||
</dl> | ||
|
||
</dl> | ||
|
||
</dl> | ||
|
||
### Animation Trigger Types ### {#trigger-types} | ||
|
||
The behavior an [=animation trigger=] applies to its associated [=animation=]’s | ||
playback is defined by its <dfn export>animation trigger type</dfn>, | ||
which can be one of the following: | ||
|
||
<dl dfn-type=value dfn-for='animation trigger type'> | ||
<dt><dfn>once</dfn> | ||
<dd> | ||
The ''primary'' behavior is [=play an animation|triggering=] the associated animation. | ||
|
||
<dt><dfn>repeat</dfn> | ||
<dd> | ||
The ''primary'' behavior is [=play an animation|triggering=] the associated animation. | ||
The ''inverse'' behavior is resetting the [=animation trigger state=] back to ''animation trigger state/idle''. | ||
|
||
<dt><dfn>alternate</dfn> | ||
<dd> | ||
<dl class=switch> | ||
: if the |did trigger| flag is false, | ||
:: | ||
The ''primary'' behavior is [=play an animation|triggering=] the associated animation. | ||
|
||
: Otherwise, | ||
:: | ||
The ''primary'' behavior is [=reverse an animation|reversing=] the associated animation. | ||
|
||
</dl> | ||
|
||
The ''inverse'' behavior is [=reverse an animation|reversing=] the associated animation. | ||
|
||
<dt><dfn>state</dfn> | ||
<dd> | ||
The ''primary'' behavior is [=play an animation|triggering or resuming=] the associated animation. | ||
The ''inverse'' behavior is [=pause an animation|pausing=] the associated animation. | ||
</dl> | ||
|
||
Issue: Need to bike-shed the name for type "state" type. | ||
|
||
### Animation Trigger Ranges ### {#trigger-ranges} | ||
|
||
An [=animation trigger=] has at least one [=animation attachment range|range=], | ||
its <dfn>default range</dfn>, which defines its [=active interval=]. | ||
This range defines when the [=animation trigger|trigger=] is in its ''animation trigger state/primary'' state, | ||
as specified in [[#trigger-state]]. | ||
|
||
An [=animation trigger=] may also have a second [=animation attachment range|range=], | ||
the <dfn>exit range</dfn>. The [=exit range=] is used to replace [=default range=] and extend | ||
the [=active interval=] of an [=animation trigger=] |trigger| as follows: | ||
|
||
<dl class=switch> | ||
: If |trigger| is inside its [=active interval=], | ||
:: | ||
It’s attached to its [=exit range=]. | ||
|
||
: Otherwise, | ||
:: | ||
It’s attached to its [=default range=]. | ||
|
||
</dl> | ||
|
||
Issue: Should we specify that that exit range’s edges can only be equal to or greater than the default range’s edges? | ||
|
||
Issue: Do we need to specify the process for determining the effective attachment range in the HTML Processing Model? | ||
|
||
|
||
<!-- End of timing model --> | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any reason not to define this shorthand in the same section as the longhand properties it is a short-hand for?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I started with everything next to the short-hand, but later had to move more and properties close to the definition of Trigger below. I'll refactor it now anyway, to have the properties here, and the definitions in web-animaitons-1, as you said.