[css-view-transitions-1] Fix timing of resolving "update callback done" promise #10302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… done" promise The "update callback done" promise should always be resolved right after the update callback is called, even in failure cases. This is what certain WPTs expect, for instance: css/css-view-transitions/duplicate-tag-rejects-start.html
nt1m
added a commit
to nt1m/WebKit
that referenced
this pull request
May 9, 2024
https://bugs.webkit.org/show_bug.cgi?id=273969 rdar://127834364 Reviewed by NOBODY (OOPS!). Implements: w3c/csswg-drafts@9d5ed6f w3c/csswg-drafts#10302 Also fix duplicate-tag-rejects-start.html to not check for updateCallbackDone promise timing twice. The correct timing is: “update callback done -> ready rejects -> finished resolves” (as the "Skip the view transition" algorithm expects) * LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/duplicate-tag-rejects-start.html: * Source/JavaScriptCore/runtime/JSPromise.cpp: (JSC::JSPromise::markAsHandled): (JSC::JSPromise::rejectAsHandled): * Source/JavaScriptCore/runtime/JSPromise.h: * Source/WebCore/bindings/js/JSDOMPromiseDeferred.h: (WebCore::DeferredPromise::markAsHandled const): * Source/WebCore/dom/ViewTransition.cpp: (WebCore::ViewTransition::callUpdateCallback): (WebCore::ViewTransition::setupViewTransition):
nt1m
added a commit
to nt1m/WebKit
that referenced
this pull request
May 9, 2024
https://bugs.webkit.org/show_bug.cgi?id=273969 rdar://127834364 Reviewed by NOBODY (OOPS!). Implements: w3c/csswg-drafts@9d5ed6f w3c/csswg-drafts#10302 Also fix duplicate-tag-rejects-start.html to not check for updateCallbackDone promise timing twice. The correct timing is: “update callback done -> ready rejects -> finished resolves” (as the "Skip the view transition" algorithm expects) * LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/duplicate-tag-rejects-start.html: * Source/JavaScriptCore/runtime/JSPromise.cpp: (JSC::JSPromise::markAsHandled): (JSC::JSPromise::rejectAsHandled): * Source/JavaScriptCore/runtime/JSPromise.h: * Source/WebCore/bindings/js/JSDOMPromiseDeferred.h: (WebCore::DeferredPromise::markAsHandled const): * Source/WebCore/dom/ViewTransition.cpp: (WebCore::ViewTransition::callUpdateCallback): (WebCore::ViewTransition::setupViewTransition):
nt1m
added a commit
to nt1m/WebKit
that referenced
this pull request
May 9, 2024
https://bugs.webkit.org/show_bug.cgi?id=273969 rdar://127834364 Reviewed by NOBODY (OOPS!). Implements: w3c/csswg-drafts@9d5ed6f w3c/csswg-drafts#10302 This makes the algorithm only react to the update callback from a single place. Also fix duplicate-tag-rejects-start.html to not check for updateCallbackDone promise timing twice. The correct timing is: “update callback done -> ready rejects -> finished resolves” (as the "Skip the view transition" algorithm expects) * LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/duplicate-tag-rejects-start.html: * Source/JavaScriptCore/runtime/JSPromise.cpp: (JSC::JSPromise::markAsHandled): (JSC::JSPromise::rejectAsHandled): * Source/JavaScriptCore/runtime/JSPromise.h: * Source/WebCore/bindings/js/JSDOMPromiseDeferred.h: (WebCore::DeferredPromise::markAsHandled const): * Source/WebCore/dom/ViewTransition.cpp: (WebCore::ViewTransition::callUpdateCallback): (WebCore::ViewTransition::setupViewTransition):
khushalsagar
approved these changes
May 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "update callback done" promise should always be resolved right after the update callback is called, even in failure cases. This is what certain WPTs expect, for instance: css/css-view-transitions/duplicate-tag-rejects-start.html