Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cssom] Throw on empty 'nested declarations rule' insertion #10519

Merged
merged 1 commit into from
Jul 2, 2024
Merged

[cssom] Throw on empty 'nested declarations rule' insertion #10519

merged 1 commit into from
Jul 2, 2024

Conversation

andruud
Copy link
Member

@andruud andruud commented Jul 2, 2024

The current text expects 'parse a CSS declaration block' to return a syntax error, which it never actually returns.

Follow-up to 7d8f87c.

@andruud
[cssom] Throw on empty 'nested declarations rule' insertion
583a0b5 
The current text expects 'parse a CSS declaration block' to return
a syntax error, which it never actually returns.

Follow-up to 7d8f87c.
@andruud andruud requested a review from emilio July 2, 2024 14:11
emilio
emilio approved these changes Jul 2, 2024
View reviewed changes
Copy link
Collaborator

@emilio emilio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me, can you file an issue to get this change sanity-checked by the group (ideally reference it from the commit message but I guess not a huge deal)?

@emilio emilio merged commit 1839d6a into w3c:main Jul 2, 2024
1 check passed
@andruud andruud mentioned this pull request Jul 2, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emilio emilio emilio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@andruud @emilio