Revert "[cssom-view] Kill DOMRectList. Fixes https://www.w3.org/Bugs/… #1499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Public/show_bug.cgi?id=26200" This reverts commit ebc0d23. See #1479
|
Sounds fine assuming it's a clean revert. I didn't read the actual diff. |
annevk
reviewed
Jun 25, 2017
cssom-view/Overview.bs
Outdated
| 1. If the element on which it was invoked does not have an associated <a>layout box</a> return an empty sequence and stop this algorithm. | ||
| 1. If the element has an associated <a>SVG layout box</a> return a sequence containing a single {{DOMRect}} object that describes the bounding box of the element as defined by the SVG specification, applying the <a>transforms</a> that apply to the element and its ancestors. | ||
| 1. Return a sequence containing {{DOMRect}} objects in content order, one for each <a spec=css-break>box fragment</a>, describing its border area (including those with a height or width of zero) with the following constraints: | ||
| 1. If the element on which it was invoked does not have an associated <a>layout box</a> return an empty {{DOMRectList}} and stop this algorithm. |
|
web-platform-tests/wpt#6299 is already merged, I didn't notice there were two spec changes involved. |
|
I went about adding the "object" requested, but don't have write access to this repo. @tabatkins, can you add "object" and merge this? |
|
Done 👍 |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…Public/show_bug.cgi?id=26200"
This reverts commit ebc0d23.
See #1479
Tests: web-platform-tests/wpt#6299