Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[css-box] Fixed example 26 #1698

Closed
wants to merge 3 commits into from
Closed

Conversation

retrazil
Copy link
Contributor

@retrazil retrazil commented Aug 5, 2017

Example 26 has lot of errors. I've replaced ambiguous 'body' with 'content'. Also attached all the container (or boxes/ pseudo code divs) names with actual css ids and replaced pseudo code like with actual div tags.

@tabatkins
Copy link
Member

None of these are actually wrong - it's not valid HTML, sure, but the tag structure and selectors are otherwise fine. And the 'border' declaration is correct as is.

@retrazil
Copy link
Contributor Author

retrazil commented Aug 8, 2017

Why use pseudo code in one example while all the rest of the examples contain valid html code ? there can be easily confused with the actual html tag.

'border' declaration is correct like you say.

@frivoal
Copy link
Collaborator

frivoal commented Jan 25, 2018

@tabatkins This PR should be closed or accepted. Keeping it open forever does not help anyone.

@retrazil The original example isn't pseudo code, it would work in if loaded in a browser. Yes, it does use non existing elements with made up semantics, but the valid markup you suggested is more verbose, which may distracts from the point the example wants to make.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants