Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[css-animations][css-conditional][css-font-loading][cssom-view][cssom][mediaqueries] IDL: Use [Exposed] consistently #1749

Merged
merged 3 commits into from
Sep 15, 2017

Conversation

zcorpan
Copy link
Member

@zcorpan zcorpan commented Aug 22, 2017

This is necessary for whatwg/webidl#365.


cc @annevk @tobie

…][mediaqueries] IDL: Use [Exposed] consistently

This is necessary for whatwg/webidl#365.
@tabatkins
Copy link
Member

👍 from me

Copy link
Member

@tobie tobie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@@ -1087,6 +1088,7 @@ The <code>CSSKeyframeRule</code> Interface</h3>
IDL Definition</h4>

<pre class="idl">
[Exposed=Window]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indentation seems off here.

zcorpan added a commit to web-platform-tests/wpt that referenced this pull request Aug 23, 2017
CSSOM's IDL was duplicated in interfaces/cssom.idl and
cssom/interfaces.html, and both were out of date. CSSOM View did
not have any IDL tests.

Fix CSSOM IDL test, add more objects to be tested, and add IDL
tests for CSSOM View.

Includes [Exposed=Window] per w3c/csswg-drafts#1749.
@zcorpan
Copy link
Member Author

zcorpan commented Aug 23, 2017

I did not add Exposed for interfaces with NoInterfaceObject. Should that be added?

$ grep -r --include="*.bs" "NoInterfaceObject" .
./css-font-loading/Overview.bs:		[NoInterfaceObject]
./css-regions/Overview.bs:		[NoInterfaceObject]
./css-regions/Overview.bs:		<li>Region interface is now a supplemental interface with the [NoInterfaceObject] extended attribute.</li>
./cssom/Overview.bs:[NoInterfaceObject]
./cssom/Overview.bs:[NoInterfaceObject]
./cssom-view/Overview.bs:[NoInterfaceObject]

@annevk
Copy link
Member

annevk commented Aug 23, 2017

Yeah, I think so.

@zcorpan
Copy link
Member Author

zcorpan commented Aug 23, 2017

Done, also updated web-platform-tests/wpt#6982

zcorpan added a commit to web-platform-tests/wpt that referenced this pull request Sep 15, 2017
CSSOM's IDL was duplicated in interfaces/cssom.idl and
cssom/interfaces.html, and both were out of date. CSSOM View did
not have any IDL tests.

Fix CSSOM IDL test, add more objects to be tested, and add IDL
tests for CSSOM View.

Includes [Exposed=Window] per w3c/csswg-drafts#1749.
@zcorpan zcorpan merged commit c2541c8 into master Sep 15, 2017
@zcorpan zcorpan deleted the zcorpan/idl-exposed branch September 15, 2017 11:39
@syncbot syncbot restored the zcorpan/idl-exposed branch October 4, 2017 13:02
@plinss plinss deleted the zcorpan/idl-exposed branch November 7, 2017 22:53
@syncbot syncbot restored the zcorpan/idl-exposed branch November 7, 2017 23:38
@plinss plinss deleted the zcorpan/idl-exposed branch November 7, 2017 23:54
rachelandrew pushed a commit to rachelandrew/web-platform-tests that referenced this pull request Nov 8, 2017
CSSOM's IDL was duplicated in interfaces/cssom.idl and
cssom/interfaces.html, and both were out of date. CSSOM View did
not have any IDL tests.

Fix CSSOM IDL test, add more objects to be tested, and add IDL
tests for CSSOM View.

Includes [Exposed=Window] per w3c/csswg-drafts#1749.
jakearchibald pushed a commit to jakearchibald/web-platform-tests that referenced this pull request Nov 16, 2017
CSSOM's IDL was duplicated in interfaces/cssom.idl and
cssom/interfaces.html, and both were out of date. CSSOM View did
not have any IDL tests.

Fix CSSOM IDL test, add more objects to be tested, and add IDL
tests for CSSOM View.

Includes [Exposed=Window] per w3c/csswg-drafts#1749.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants