Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[css-color-4] consistently name color-mod() #2196

Merged
merged 1 commit into from
Jan 18, 2018
Merged

[css-color-4] consistently name color-mod() #2196

merged 1 commit into from
Jan 18, 2018

Conversation

jonathantneal
Copy link
Contributor

@jonathantneal jonathantneal commented Jan 17, 2018

Uses the color-mod() function name consistently in order to avoid confusion with the color() function.

Resolves #868

This avoids confusion with the very real color() function
@svgeesus svgeesus merged commit a21cc8f into w3c:master Jan 18, 2018
@jonathantneal jonathantneal deleted the fix/css-color-4-color-mod branch January 18, 2018 16:21
@praveenpuglia
Copy link
Contributor

I see this being merged but..
here - https://www.w3.org/TR/css-color-4/#funcdef-color-mod

I still see inconsistencies.
Example -
Example 11 in the spec uses the word color and not color-mod as function name.

Will this be updated later or something?

@AmeliaBR
Copy link
Contributor

@praveenpuglia Merging a commit into the master branch automatically updates the editor's draft at https://drafts.csswg.org/css-color-4/

The "TR" link on w3.org is updated less frequently, after a formal process with the W3C.

@praveenpuglia
Copy link
Contributor

But the draft only has a link to color-mod function which redirects to the TR page. This seems confusing. Couldn't the latest version live in the editor's draft instead of pointing to the TR?

@AmeliaBR
Copy link
Contributor

Ah, it looks like the entire color-mod proposal was removed (while waiting for a major syntax re-writing) in 034b063#diff-4dcdf0ecb00e997ce9e5b7d522a0cb62

But one reference remained by accident, and because it no longer had any definition in the same file to link to, it was automatically linked to the last TR definition.

Could you file a separate issue, and tag @tabatkins in it?

@praveenpuglia
Copy link
Contributor

Sure! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants