Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[css-ruby-1] Bikeshed improvements related to property values #224

Merged
merged 2 commits into from Jun 23, 2016
Merged

[css-ruby-1] Bikeshed improvements related to property values #224

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dfa5b34
[css-ruby-1] Bikeshed improvements related to property values (#144)
SebastianZ Jun 23, 2016
9c14f09
Fixed property definitions (addressing comments by @tabatkins)
SebastianZ Jun 23, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
124 changes: 26 additions & 98 deletions css-ruby/Overview.bs
View file
Open in desktop
Expand Up @@ -160,14 +160,10 @@ Ruby-specific 'display' Values</h3>
authors must map document language elements to ruby elements;
this is done with the 'display' property.

<table class="propdef">
<tr>
<th>Name:
<td>display
<tr>
<th><a href="#values">New Values</a>:
<td>ruby | ruby-base | ruby-text | ruby-base-container | ruby-text-container
</table>
<pre class="propdef">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Put a "partial" class on this as well, so it doesn't try to claim to be defining the 'display' property.

Name: display
New values: ruby | ruby-base | ruby-text | ruby-base-container | ruby-text-container
</pre>

<p>The following new 'display' values assign ruby layout roles to an arbitrary element:

Expand Down Expand Up @@ -897,38 +893,13 @@ Ruby Formatting Properties</h2>
<h3 id="rubypos">
Ruby Positioning: the 'ruby-position' property</h3>

<table class="propdef">
<tr>
<th>Name:
<td><dfn>ruby-position</dfn>
<tr>
<th><a href="#values">Value</a>:
<td>[ over | under | inter-character ]
<tr>
<th>Initial:
<td>over
<tr>
<th>Applies to:
<td>ruby annotation containers
<tr>
<th>Inherited:
<td>yes
<tr>
<th>Percentages:
<td>N/A
<tr>
<th>Media:
<td>visual
<tr>
<th>Computed value:
<td>specified value
<tr>
<th>Animatable:
<td>no
<tr>
<th>Canonical order:
<td><abbr title="follows order of property value definition">per grammar</abbr>
</table>
<pre class="propdef">
Name: ruby-position
Value: [ over | under | inter-character ]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the brackets.

Initial: over
Applies to: ruby annotation containers
Inherited: yes
</pre>

<p>This property controls position of the ruby text with respect to its base.
Values have the following meanings:
Expand Down Expand Up @@ -994,38 +965,13 @@ Ruby Positioning: the 'ruby-position' property</h3>
<h3 id="collapsed-ruby">
Sharing Annotation Space: the 'ruby-merge' property</h3>

<table class="propdef">
<tr>
<th>Name:
<td><dfn>ruby-merge</dfn>
<tr>
<th><a href="#values">Value</a>:
<td>separate | collapse | auto
<tr>
<th>Initial:
<td>separate
<tr>
<th>Applies to:
<td>ruby annotation containers
<tr>
<th>Inherited:
<td>yes
<tr>
<th>Percentages:
<td>N/A
<tr>
<th>Media:
<td>visual
<tr>
<th>Computed value:
<td>specified value
<tr>
<th>Animatable:
<td>no
<tr>
<th>Canonical order:
<td><abbr title="follows order of property value definition">per grammar</abbr>
</table>
<pre class="propdef">
Name: ruby-merge
Value: separate | collapse | auto
Initial: separate
Applies to: ruby annotation containers
Inherited: yes
</pre>

<p>
This property controls how ruby annotation boxes should be rendered
Expand Down Expand Up @@ -1096,32 +1042,14 @@ Sharing Annotation Space: the 'ruby-merge' property</h3>
<h3 id="ruby-align-property"><span id="rubyalign"></span>
Ruby Text Distribution: the 'ruby-align' property</h3>

<table class="propdef">
<tr>
<th>Name:
<td><dfn>ruby-align</dfn>
<tr>
<th><a href="#values">Value</a>:
<td>start | center | space-between | space-around
<tr>
<th>Initial:
<td>space-around
<tr>
<th>Applies to:
<td>ruby bases, ruby annotations, ruby base containers, ruby annotation containers
<tr>
<th>Inherited:
<td>yes
<tr>
<th>Percentages:
<td>N/A
<tr>
<th>Media:
<td>visual
<tr>
<th>Computed value:
<td>specified value (except for initial and inherit)
</table>
<pre class="propdef">
Name: ruby-align
Value: start | center | space-between | space-around
Initial: space-around
Applies to: ruby bases, ruby annotations, ruby base containers, ruby annotation containers
Inherited: yes
Computed value: specified value (except for ''initial'' and ''inherit'')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the parenthetical.

</pre>

<p>This property specifies how text is distributed within the various ruby boxes
when their contents do not exactly fill their respective boxes.
Expand Down