Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[css-text-4] Update several links #2415

Merged
merged 1 commit into from Mar 15, 2018
Merged

[css-text-4] Update several links #2415

merged 1 commit into from Mar 15, 2018

Conversation

xfq
Copy link
Member

@xfq xfq commented Mar 7, 2018

No description provided.

@@ -335,7 +335,7 @@ Inline breaks between boxes: the 'wrap-before'/'wrap-after' properties</h3>
<dd>
Force a <a>flex line</a> break immediately before/after the box
if the box is a <a>flex item</a>
in a <a href="https://www.w3.org/TR/css-flexbox-1/#multi_line">multi-line flex container</a>.
in a <a>multi-line flex container</a>.
Copy link
Contributor

@ewilligers ewilligers Mar 7, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member Author

@xfq xfq Mar 8, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm using Bikeshed's autolinking feature here.

I just tried this locally. When building this spec with --md-status=ED, it correctly points to https://drafts.csswg.org/css-flexbox-1/#multi-line-flex-container , but when building the spec with --md-status=WD, the link becomes https://www.w3.org/TR/css-flexbox-1/#multi_line , which doesn't exist. It might be a bug in Bikeshed/Shepherd/Specref.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I've run into this bug before. I'll merge this, and figure out the bug separately.

@@ -335,7 +335,7 @@ Inline breaks between boxes: the 'wrap-before'/'wrap-after' properties</h3>
<dd>
Force a <a>flex line</a> break immediately before/after the box
if the box is a <a>flex item</a>
in a <a href="https://www.w3.org/TR/css-flexbox-1/#multi_line">multi-line flex container</a>.
in a <a>multi-line flex container</a>.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I've run into this bug before. I'll merge this, and figure out the bug separately.

@tabatkins tabatkins merged commit b6f8d4c into w3c:master Mar 15, 2018
@xfq xfq deleted the links branch March 16, 2018 03:02
@xfq
Copy link
Member Author

xfq commented Mar 16, 2018

Thanks @tabatkins!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants