Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[css-shapes] Refer css-shapes-1 for shape-margin #2835

Merged
merged 1 commit into from Jun 27, 2018
Merged

[css-shapes] Refer css-shapes-1 for shape-margin #2835

merged 1 commit into from Jun 27, 2018

Conversation

ewilligers
Copy link
Contributor

css-shapes-2 refers to css-shapes-1 for shape-margin.

css-shapes-2 (like css-shapes-1) refers to css-masking-1 for 'nonzero'
and 'evenodd'.

@ericwilligers
[css-shapes] Refer css-shapes-1 for shape-margin
0cdbb49 
css-shapes-2 refers to css-shapes-1 for shape-margin.

css-shapes-2 (like css-shapes-1) refers to css-masking-1 for 'nonzero'
and 'evenodd'.
astearns
astearns approved these changes Jun 27, 2018
View reviewed changes
Copy link
Member

@astearns astearns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine for now. When we update level 2 to be more than a diff spec, we should update the shape-margin link to level 2

@ewilligers ewilligers merged commit 1d1e45d into w3c:master Jun 27, 2018
@ewilligers ewilligers deleted the shapes-nonzero-evenodd branch June 27, 2018 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@astearns astearns astearns approved these changes

@atanassov atanassov Awaiting requested review from atanassov

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ewilligers @astearns @ericwilligers