[css-overflow-3] Inserting the block ellipsis should not cause relayouts #3263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frivoal
force-pushed
the
overflow-2905
branch
3 times, most recently
from
30c7d2e
to
0a8c9b5
Compare
Treating it as ''line-height: 0'' should handle that. See w3c#2905
|
reviewed by @fantasai |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Treating it as ''line-height: 0'' should handle that.
This is slightly different from the resolution taken in #2905, but this should be equally safe with regards to relayout, while still allowing text alignment and especially justification to work fine.