Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[css-grid-1] Broken anchor links, fix for issue #3883 #3884

Closed
wants to merge 1 commit into from
Closed

[css-grid-1] Broken anchor links, fix for issue #3883 #3884

wants to merge 1 commit into from

Conversation

huijing
Copy link
Contributor

@huijing huijing commented May 1, 2019

No description provided.

@ewilligers
Copy link
Contributor

Marked as non substantive for IPR from ash-nazg.

svgeesus
svgeesus reviewed May 2, 2019
View reviewed changes
Copy link
Contributor

@svgeesus svgeesus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm. It would be preferable to fix this by finding out why the auto-linker is not working, rather than hard-coding the link.

@tabatkins
Copy link
Member

Yeah, I'm not willing to merge a manual link, this is something wrong with Bikeshed. I'll report separately.

@tabatkins tabatkins closed this May 3, 2019
@tabatkins
Copy link
Member

(Thanks for reporting the problem tho, @huijing!)

@tabatkins
Copy link
Member

And reported as speced/bikeshed#1466

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@svgeesus svgeesus svgeesus left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@huijing @ewilligers @tabatkins @svgeesus