Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[web-animations-1] Add advice about not using indefinitely filling animations #3901

Merged
merged 1 commit into from May 9, 2019

Conversation

birtles
Copy link
Contributor

@birtles birtles commented May 9, 2019

No description provided.

Copy link
Contributor

@stephenmcgruer stephenmcgruer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for doing this. I really appreciate the inclusion of 'ways you should actually do this' as well.

I wonder if we could get something added to https://developer.mozilla.org/en-US/docs/Web/API/EffectTiming/fill as well?

@birtles
Copy link
Contributor Author

birtles commented May 9, 2019

I wonder if we could get something added to https://developer.mozilla.org/en-US/docs/Web/API/EffectTiming/fill as well?

Sure! Will do. (I'll merge this first though so I can link to it.)

Also, I'm sure you're aware but just in case, MDN is publicly editable (you can login with GitHub) so feel free to edit away if you notice anything amiss.

@birtles birtles merged commit bebe3a0 into w3c:master May 9, 2019
@birtles birtles deleted the fill-advisement branch May 9, 2019 23:48
@birtles
Copy link
Contributor Author

birtles commented May 10, 2019

@stephenmcgruer
Copy link
Contributor

Also, I'm sure you're aware but just in case, MDN is publicly editable (you can login with GitHub) so feel free to edit away if you notice anything amiss.

I was not aware! Thanks for letting me know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants