Link to CSS Values definition of ex units #3917
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Link to css-values definition of ex units instead of css-inline-3 leading-trim keyword ex. (Specs already link to css-values for em.) css-cascade-3 links to mediaqueries-4 instead of css-cascade-4 for media-query.
ewilligers
added
css-cascade-3
css-cascade-4
|
@tabatkins please review. An alternative would be for bikeshed to by default |
|
I don't really like special-casing things like that. I'd rather have a linking error than silently link to the wrong thing. Thanks for the fixes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to css-values definition of ex units
instead of css-inline-3 leading-trim keyword ex.
(Specs already link to css-values for em.)
css-cascade-3 links to mediaqueries-4 instead
of css-cascade-4 for media-query.