Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[web-animations-2] Update the GroupEffect sections in level 2 spec #4302

Closed
wants to merge 0 commits into from

Conversation

yi-gu
Copy link
Contributor

@yi-gu yi-gu commented Sep 13, 2019

We have started looking more closely at GroupEffect (explainer, prototype). As such we want to ensure its specification moves forward as well as part of [1].

In this PR we made some fairly minor changes to the current design. PTAL. Thanks!

[1] #4008

@stephenmcgruer stephenmcgruer added the web-animations-2 Current Work label Sep 13, 2019
@birtles
Copy link
Contributor

birtles commented Sep 16, 2019

I tried to build this PR locally but got a bunch of link errors. Is it supposed to work?

Also, any chance we could replace those PNG images with SVG images in a similar style to the existing ones? (Preferably not the UML class diagram style.)

I'm not totally convinced that StaggerEffect is necessary. It seems a lot of stagger-type effects use a decreasing delta (e.g. 0s, 1s, 1.8s, 2.5s, 3s, 3.3s, 3.4s) or use some degree of random jitter in the amount of stagger. It would seem like script can easily generate a ParallelEffect to achieve these cases and the original StaggerEffect case.

The link to the explainer at the start of this thread also appears to be broken.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
web-animations-2 Current Work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants