Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[web-animations-1][web-animations-2] Move iterationComposite to web-animations-2 #4303

Merged
merged 4 commits into from
Sep 16, 2019

Conversation

stephenmcgruer
Copy link
Contributor

This PR moves the iterationComposite concept from the level 1 spec to the level 2 spec, as motivated in #4300

@stephenmcgruer
Copy link
Contributor Author

Antoine, Brian - not sure what we should do with WPT tests for iterationComposite - should they be marked tentative, are we somehow else differentiating level-2 tests, or are we just leaving them all and its up to each of us to maintain what we think are the level-1-relevant tests?

@flackr
Copy link
Contributor

flackr commented Sep 13, 2019

I'd suggest marking them tentative for now, although perhaps longterm it would make sense to differentiate spec levels in wpt. I seem to recall ideas around including or referencing the test results from the spec at which point being able to differentiate spec level seems desirable. Thoughts, @foolip ?

@foolip
Copy link
Member

foolip commented Sep 13, 2019

If level 2 is published somewhere then they need not be tentative. You can add a link to the spec and if you need to filter based on those links perhaps we can come up with something in wpt.fyi?

@stephenmcgruer stephenmcgruer changed the title Move iterationComposite to web-animations-2 [web-animations-1][web-animations-2] Move iterationComposite to web-animations-2 Sep 13, 2019
@stephenmcgruer
Copy link
Contributor Author

perhaps we can come up with something in wpt.fyi?

I think this is a great idea! I'm not sure how widespread the use of the <link rel="help" href="spec-link"> tags are, but the ability to search the whole of wpt.fyi by spec would be pretty neat, especially as we look at different levels of the same spec. Though to be fair, I'm not sure if anyone consistently keeps those separate so maybe that would limit impact...

@foolip
Copy link
Member

foolip commented Sep 13, 2019

Feature request is at web-platform-tests/wpt.fyi#65.

Copy link
Contributor

@birtles birtles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me with the suggested changes.

web-animations-2/Overview.bs Outdated Show resolved Hide resolved
web-animations-2/Overview.bs Outdated Show resolved Hide resolved
web-animations-2/Overview.bs Outdated Show resolved Hide resolved
web-animations-2/Overview.bs Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants