Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[css-syntax] make "plus sign" match other 2 items #4473

Merged
merged 1 commit into from
Oct 31, 2019

Conversation

skratchdot
Copy link
Contributor

@skratchdot skratchdot commented Oct 31, 2019

when consuming a token, the first instruction for PLUS SIGN, HYPHEN-MINUS, and FULL STOP are all the same, but the PLUS SIGN instructions are missing a comma.

visit: https://www.w3.org/TR/css-syntax-3/#consume-comment

search the page for:

If the input stream starts with a number, reconsume the current input code point, consume a numeric token and return it. 

there is only 1 instance.

search the page for:

If the input stream starts with a number, reconsume the current input code point, consume a numeric token, and return it.

there are 2 instances.

i think all 3 versions should match.

when consuming a token, the first instruction for PLUS SIGN, HYPHEN-MINUS, and FULL STOP are all the same, but the PLUS SIGN instructions are missing a comma.
@skratchdot
Copy link
Contributor Author

Marked as non substantive for IPR from ash-nazg.

@skratchdot
Copy link
Contributor Author

If removing the comma is preferred for all 3, then I will make that changes. Just let me know.

@tabatkins tabatkins merged commit 1bf7074 into w3c:master Oct 31, 2019
@tabatkins
Copy link
Member

Nope, oxford comma is definitely preferred, I just missed it in that spot. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants