Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[scroll-anchoring-1] Allow anchor nodes to be any non-atomic inline box #4682

Merged
merged 2 commits into from Jan 18, 2020

Conversation

chrishtr
Copy link
Contributor

This resolves issue #4247 .

@chrishtr
Copy link
Contributor Author

WPT tests for this include:

css/css-scroll-anchoring/image-001.html
css/css-scroll-anchoring/inline-block-002.html

@chrishtr chrishtr requested a review from emilio January 18, 2020 01:01
@@ -81,7 +81,7 @@ and close to the block start edge of its <a>optimal viewing region</a>.
Note: If the user agent does not support the 'scroll-padding' property,
the optimal viewing region of the scrolling box is equivalent to its <a>content area</a>.

The anchor node is either a non-anonymous <a>block box</a> or a <a>text node</a>.
An anchor node can be any non-<a>atomic inline</a> <a>box</a>.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this reads a bit weird, but it may be because I'm not a native English speaker. When I see this, it kinda wants to read "Any inline box which is non-atomic", which is exactly the opposite of what we want. I guess in the spec it would be a bit clearer because atomic inline is a concept on its own, but maybe this should read "any box except <a>inline boxes</a> that are non-<a for="atomic inline">atomic</a>" or such (whatever makes bikeshed generate the right markup)?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adjusted to make it clearer.

@emilio
Copy link
Collaborator

emilio commented Jan 18, 2020

(And thanks so much for taking time to update the spec!)

@chrishtr chrishtr merged commit 4f36434 into w3c:master Jan 18, 2020
@chrishtr chrishtr deleted the inlineblock branch January 18, 2020 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants