-
Notifications
You must be signed in to change notification settings - Fork 645
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[scroll-animations-1] Removed fill from ScrollTimeline #4750
[scroll-animations-1] Removed fill from ScrollTimeline #4750
Conversation
…line in favor of returning Infinity values for before start and after end states of the timeline.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BTW I think the examples need to be updated to have the animation use correct fill values.
I think they were previously broken as well. For example take the example "Scrollable picture-story show" where two balls are colliding. We expect that past end of scroll timeline (350px) the effect stays the same. This meant previously for timeline to have fill: forwards
which it didn't. But now the #union-circle animation should have 'fill:forwards' .
Please review the examples and make sure they have the correct fill value.
https://drafts.csswg.org/scroll-animations-1/#scrollable-animation-usecase
I've commented a number of times in #2066 that I'd prefer we avoid infinity values and instead use explicit states for this. |
… after scrolling past the end of the timeline
I have changed the returned values to 0 and time range since I believe we have settled on that at this point. I also updated the examples as requested. |
Thank you! |
Removed fill from ScrollTimeline in favor of returning Infinity values for before start and after end states of the timeline.
Also fixed edit link by correcting shortname.
Related Issues:
#2066 (Discussion for change)
#4347 (Solved by this change)