Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[scroll-animations-1] Removed fill from ScrollTimeline #4750

Merged
merged 5 commits into from
Feb 12, 2020

Conversation

JTensai
Copy link
Contributor

@JTensai JTensai commented Feb 5, 2020

Removed fill from ScrollTimeline in favor of returning Infinity values for before start and after end states of the timeline.

Also fixed edit link by correcting shortname.

Related Issues:
#2066 (Discussion for change)
#4347 (Solved by this change)

…line in favor of returning Infinity values for before start and after end states of the timeline.
Copy link
Contributor

@majido majido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BTW I think the examples need to be updated to have the animation use correct fill values.

I think they were previously broken as well. For example take the example "Scrollable picture-story show" where two balls are colliding. We expect that past end of scroll timeline (350px) the effect stays the same. This meant previously for timeline to have fill: forwards which it didn't. But now the #union-circle animation should have 'fill:forwards' .

Please review the examples and make sure they have the correct fill value.

https://drafts.csswg.org/scroll-animations-1/#scrollable-animation-usecase

@birtles
Copy link
Contributor

birtles commented Feb 10, 2020

I've commented a number of times in #2066 that I'd prefer we avoid infinity values and instead use explicit states for this.

@JTensai
Copy link
Contributor Author

JTensai commented Feb 10, 2020

I have changed the returned values to 0 and time range since I believe we have settled on that at this point. I also updated the examples as requested.

@birtles
Copy link
Contributor

birtles commented Feb 12, 2020

I have changed the returned values to 0 and time range since I believe we have settled on that at this point.

Thank you!

scroll-animations-1/Overview.bs Show resolved Hide resolved
@stephenmcgruer stephenmcgruer merged commit 0a39585 into w3c:master Feb 12, 2020
@JTensai JTensai deleted the remove-fill-from-scroll-timeline branch February 12, 2020 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants