Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[css-text-3] replaced elements and atomic inlines with non default line-break #4755

Closed
wants to merge 3 commits into from

Conversation

frivoal
Copy link
Collaborator

@frivoal frivoal commented Feb 7, 2020

This is a follow up to #4576

This makes replaced elements and atomic inlines with non default values for line-break behave the same as characters with line-breaking class ID for line breaking purposes. This gives the expected behavior for images used as “gaiji” and as emoji.

This cannot be the default behavior for compat reasons, but having it as an opt-in based on the rarely used line-break property should be safe, and opens up for further tweaking of the line breaking behavior via the usual set of properties.

…ne-break

This is a follow up to w3c#4576

This makes replaced elements and atomic inlines with non default
line-break behave the same as characters with line-breaking class ID.
This gives the expected behavior for images used as “gaiji” and as
emoji.

This cannot be the default behavior for compat reasons,
but having it as an opt-in based on the rarely used line-break property
should be safe.
@kojiishi
Copy link
Contributor

I would like us to use any other properties than line-break for this purpose.

The effect of using incorrect values of line-break is visible only to some scripts. It is possible for authors to misunderstand and apply, for instance:

html { line-break: strict; }

but authors will not notice it has undesired side effects until they test it with CJK content. This can lead to a situation where global sites to use undesired typography only for CJK content.

/cc @r12a @himorin

@kojiishi kojiishi added i18n-clreq Chinese language enablement i18n-jlreq Japanese language enablement i18n-tracker Group bringing to attention of Internationalization, or tracked by i18n but not needing response. labels Feb 18, 2020
@fantasai
Copy link
Collaborator

fantasai commented Apr 3, 2020

@kojiishi The initial value of line-break right now is auto, so non-CJK sites can use line-break: normal to make the change in behavior. Also I think, it's easy to say "put it on the image", img { line-break: normal; }, then it won't affect any other characters. Maybe we can make this an example so it's clearer.

@frivoal
Copy link
Collaborator Author

frivoal commented Apr 13, 2020

@fantasai, added an example: 34c697b. Feedback welcome.

@frivoal
Copy link
Collaborator Author

frivoal commented May 6, 2020

Closed as the resolution in #4949 (comment) decided on a different approach.

@frivoal frivoal closed this May 6, 2020
@frivoal frivoal deleted the css-text-4576 branch June 5, 2020 01:52
@frivoal frivoal added the Testing Unnecessary Memory aid - issue doesn't require tests label Dec 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Closed Rejected as Wontfix by CSSWG Resolution css-text-3 Current Work i18n-clreq Chinese language enablement i18n-jlreq Japanese language enablement i18n-tracker Group bringing to attention of Internationalization, or tracked by i18n but not needing response. Testing Unnecessary Memory aid - issue doesn't require tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants