Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert CSS2 to Bikeshed #5196

Merged
merged 38 commits into from Jul 1, 2020
Merged

Convert CSS2 to Bikeshed #5196

merged 38 commits into from Jul 1, 2020

Commits on Jun 10, 2020

  1. Configuration menu
    Copy the full SHA
    5c408d1 View commit details
    Browse the repository at this point in the history
  2. [CSS2] Add way more dfn elements

    This primarily marks up many (but not all) property value definitions as
    being property values for their respective properties. The choice is
    mostly those keywords that exist in other specs; this should be further
    completed in due course.
    gsnedders committed Jun 10, 2020
    Configuration menu
    Copy the full SHA
    d3c598b View commit details
    Browse the repository at this point in the history
  3. [CSS2] lowercase all HTML tag names

    This is in preparation for conversion to Bikeshed; both because the
    forthcoming conversion relies on parse/serialize cycles (using html5lib,
    which doesn't support preserving case) and because Bikeshed itself
    relies on tags when they appear in BSMD being lowercase.
    gsnedders committed Jun 10, 2020
    Configuration menu
    Copy the full SHA
    646acaf View commit details
    Browse the repository at this point in the history
  4. [CSS2] eliminate new line characters within HTML tags

    This is done for the same reason as the previous commit (both Bikeshed
    conversion tooling does this, so this limits the diff in that single
    commit making blame more workable, and because Bikeshed does not handle
    tags split across multiple lines). Note that this doesn't deal with new
    lines within attributes yet.
    gsnedders committed Jun 10, 2020
    Configuration menu
    Copy the full SHA
    faf30d8 View commit details
    Browse the repository at this point in the history
  5. [CSS2] put source files through a html5lib parse/serialize cycle

    This is, similar to parent commits, prior to the Bikeshed conversion
    to make more easily ignored from blame (plus also is easier to
    review).
    
    Most of this just gets rid of ambiguous ampersands and makes quoting
    of elements consistent (the choice of quotes is done to minimize the
    size of this diff).
    gsnedders committed Jun 10, 2020
    Configuration menu
    Copy the full SHA
    df45ec4 View commit details
    Browse the repository at this point in the history
  6. [CSS2] Concatenate all source files into Overview.bs

    Plus get rid of all the old source files (to git can correctly notice
    the lines have moved) as well as the old build system and the committed
    output.
    gsnedders committed Jun 10, 2020
    Configuration menu
    Copy the full SHA
    82079cb View commit details
    Browse the repository at this point in the history
  7. [CSS2] Redo the previous concat based on parsed input

    This doesn't actually produce a particularly large diff, contrary to
    what one might expect. This primarily just gets rid of head elements.
    
    The algorithm used here is pretty simple:
    
     1. Start with cover.src, then for each chapter/appendix:
     2. Append the contents of the body element to the existing body
     3. If the style element in the head has content not yet seen, add it to
         the existing head.
    gsnedders committed Jun 10, 2020
    Configuration menu
    Copy the full SHA
    31c2acd View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    e1a0c20 View commit details
    Browse the repository at this point in the history
  9. [CSS2] include property definitions

    These BSMD blocks were generated with a modified version of the old
    propdef generator, but should be trivially correct.
    gsnedders committed Jun 10, 2020
    Configuration menu
    Copy the full SHA
    aa3e3af View commit details
    Browse the repository at this point in the history
  10. [CSS2] Prepend BS metadata

    gsnedders committed Jun 10, 2020
    Configuration menu
    Copy the full SHA
    a942a25 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    0713ae2 View commit details
    Browse the repository at this point in the history
  12. [CSS2] get rid of q0 anchors

    The q0 anchors date back to the original 2011 publication of CSS 2.1 and
    are all applied to the top-level headings within each page. As such,
    they're essentially unused (because everywhere just links to the top of
    the page). Additionally, the q0 anchors were removed when CSS 2.1 was
    edited in place in 2016 (see
    w3c#2551).
    gsnedders committed Jun 10, 2020
    Configuration menu
    Copy the full SHA
    38df2ef View commit details
    Browse the repository at this point in the history
  13. [CSS2] Move anchors to the header element itself

    The old build system always took the first anchor within the header as
    the header's anchor, but Bikeshed (very reasonably) expects the anchor
    to be on the header itself. Note in many cases we also provide "legacy"
    anchors as spans within the header; these are unchanged.
    gsnedders committed Jun 10, 2020
    Configuration menu
    Copy the full SHA
    c574d8d View commit details
    Browse the repository at this point in the history
  14. [CSS2] remove strong outwith/within dfn

    In plenty of places we have strong directly nested within dfn or dfn
    directly nested within strong; in both cases this is unnecessary as the
    goal here is purely presentational and the current TR stylesheet boldens
    all dfns anyawy.
    gsnedders committed Jun 10, 2020
    Configuration menu
    Copy the full SHA
    2a52adf View commit details
    Browse the repository at this point in the history
  15. [CSS2] turn index definitions into dfns

    The old build system generated its index through specific markup rather
    than using all dfns. In reality, most of the things marked up for the
    index are actually generally useful dfns (this is unsurprising, given
    the index contains things people might want to lookup!).
    gsnedders committed Jun 10, 2020
    Configuration menu
    Copy the full SHA
    72942e2 View commit details
    Browse the repository at this point in the history
  16. Configuration menu
    Copy the full SHA
    00311a2 View commit details
    Browse the repository at this point in the history
  17. Configuration menu
    Copy the full SHA
    02882a8 View commit details
    Browse the repository at this point in the history
  18. [CSS2] further remove strong adjacent to dfn

    This is needed as moving the IDs got rid fo a number of spans, therefore
    making new strong elements now adjacent.
    gsnedders committed Jun 10, 2020
    Configuration menu
    Copy the full SHA
    2ae086c View commit details
    Browse the repository at this point in the history
  19. [CSS2] get rid of nested dfn elements

    There's no need for this.
    gsnedders committed Jun 10, 2020
    Configuration menu
    Copy the full SHA
    03a2805 View commit details
    Browse the repository at this point in the history
  20. Configuration menu
    Copy the full SHA
    e94a3fc View commit details
    Browse the repository at this point in the history
  21. [CSS2] make "instances" of terms be autolinks

    Amusingly, some of the index instances are never actually defined.
    gsnedders committed Jun 10, 2020
    Configuration menu
    Copy the full SHA
    0139e1d View commit details
    Browse the repository at this point in the history
  22. Configuration menu
    Copy the full SHA
    88cacbd View commit details
    Browse the repository at this point in the history
  23. [CSS2] replace <pre><code class=css> with <pre class=lang-css>

    The former produces quotes around the element in the BS output; the
    latter enables CSS syntax highlighting. The latter seems like the
    better behaviour.
    gsnedders committed Jun 10, 2020
    Configuration menu
    Copy the full SHA
    981561b View commit details
    Browse the repository at this point in the history
  24. [CSS2] add lang-xml to some pre elements

    This just adds lang-xml to pre elements with no lang-* class whose
    contents can be parsed as XML, as it is unlikely for arbitrary content
    to parse as XML (potentially some of this is intended to be HTML, but
    highlighting it as if it is XML is unlikely to be harmful).
    gsnedders committed Jun 10, 2020
    Configuration menu
    Copy the full SHA
    45be582 View commit details
    Browse the repository at this point in the history
  25. [CSS2] add lang-css to some pre/code elements

    This, similar to the previous commit, adds lang-css when there is no
    lang-* class already and the content parses as CSS without any parse
    errors. As CSS is more permissive, the automated script added slightly
    too much here and a little was manually reverted.
    gsnedders committed Jun 10, 2020
    Configuration menu
    Copy the full SHA
    751db98 View commit details
    Browse the repository at this point in the history
  26. [CSS2] Remove new lines from attribute values

    This happens to only be in img[alt]
    gsnedders committed Jun 10, 2020
    Configuration menu
    Copy the full SHA
    c8c1500 View commit details
    Browse the repository at this point in the history
  27. [CSS2] add ids to all images for compatibility

    The old built system added an ID to all imgs, so we should to.
    gsnedders committed Jun 10, 2020
    Configuration menu
    Copy the full SHA
    0d7685b View commit details
    Browse the repository at this point in the history
  28. Configuration menu
    Copy the full SHA
    0206605 View commit details
    Browse the repository at this point in the history
  29. [CSS2] Change the spec reference syntax to the BSMD one

    The old CSS2 build system used [[FOO]] for a normative reference and
    [[-FOO]] for a non-normative one. BSMD uses [[!FOO]] for a normative
    reference and [[FOO] for a non-normative one.
    gsnedders committed Jun 10, 2020
    Configuration menu
    Copy the full SHA
    af3422f View commit details
    Browse the repository at this point in the history
  30. Configuration menu
    Copy the full SHA
    57d9237 View commit details
    Browse the repository at this point in the history
  31. Configuration menu
    Copy the full SHA
    050261d View commit details
    Browse the repository at this point in the history
  32. Configuration menu
    Copy the full SHA
    ef47f7e View commit details
    Browse the repository at this point in the history
  33. Configuration menu
    Copy the full SHA
    e90f531 View commit details
    Browse the repository at this point in the history
  34. [CSS2] stop requiring some old IDs

    This drops IDs for: index xrefs (x[n]), bits of generated content
    (annoying-warning, minitoc, W3C-doctype), refs (ref-*), and the index
    sections (index-[A]). Only the first might be referenced at all, and
    unfortunately they are not unique across all pages unlike all other
    anchors.
    gsnedders committed Jun 10, 2020
    Configuration menu
    Copy the full SHA
    7ca8b4c View commit details
    Browse the repository at this point in the history
  35. Configuration menu
    Copy the full SHA
    b4c2332 View commit details
    Browse the repository at this point in the history
  36. Configuration menu
    Copy the full SHA
    a73831c View commit details
    Browse the repository at this point in the history
  37. [CSS2] remove unused styles

    gsnedders committed Jun 10, 2020
    Configuration menu
    Copy the full SHA
    4a7d595 View commit details
    Browse the repository at this point in the history
  38. [CSS2] Add Appendix numbers

    gsnedders committed Jun 10, 2020
    Configuration menu
    Copy the full SHA
    c3c9bc0 View commit details
    Browse the repository at this point in the history