[css-fonts-5] Remove space in image names #6013
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
nschonni marked as non substantive for IPR from ash-nazg. |
svgeesus
approved these changes
Feb 18, 2021
|
Why are spaces in filenames a problem? |
|
It's not a terrible problem, but they need to be escaped in the |
|
I think I disagree with this change, but not enough to act upon that belief... It's fiiiiiiiiine.... 🙁 grump grump I wish we could have nice things |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternately the spaces could just be
%20escaped in thesrcvalues on the img