[css-transforms-2] Don't maintain state for whether individual transform property values are 2D or 3D. #6147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
webkit-commit-queue
pushed a commit
to WebKit/WebKit
that referenced
this pull request
Apr 29, 2021
…z" keyword for the rotate property https://bugs.webkit.org/show_bug.cgi?id=225101 Reviewed by Antti Koivisto. LayoutTests/imported/w3c: Update the tests per web-platform-tests/wpt#28712 as well as their expectations. * web-platform-tests/css/css-transforms/animation/rotate-composition-expected.txt: * web-platform-tests/css/css-transforms/animation/rotate-interpolation-expected.txt: * web-platform-tests/css/css-transforms/animation/rotate-interpolation.html: * web-platform-tests/css/css-transforms/parsing/rotate-parsing-valid-expected.txt: * web-platform-tests/css/css-transforms/parsing/rotate-parsing-valid.html: Source/WebCore: The CSS spec has changed to drop the "z" keyword or any other axis parallel to the z axis when parsing the rotate property in w3c/csswg-drafts#6147. * css/CSSComputedStyleDeclaration.cpp: (WebCore::computedRotate): * css/parser/CSSPropertyParser.cpp: (WebCore::consumeRotate): Canonical link: https://commits.webkit.org/237155@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@276768 268f45cc-cd09-0410-ab3c-d52691b4dbfc
philn
pushed a commit
to philn/old-webkit
that referenced
this pull request
May 2, 2021
…z" keyword for the rotate property https://bugs.webkit.org/show_bug.cgi?id=225101 Reviewed by Antti Koivisto. LayoutTests/imported/w3c: Update the tests per web-platform-tests/wpt#28712 as well as their expectations. * web-platform-tests/css/css-transforms/animation/rotate-composition-expected.txt: * web-platform-tests/css/css-transforms/animation/rotate-interpolation-expected.txt: * web-platform-tests/css/css-transforms/animation/rotate-interpolation.html: * web-platform-tests/css/css-transforms/parsing/rotate-parsing-valid-expected.txt: * web-platform-tests/css/css-transforms/parsing/rotate-parsing-valid.html: Source/WebCore: The CSS spec has changed to drop the "z" keyword or any other axis parallel to the z axis when parsing the rotate property in w3c/csswg-drafts#6147. * css/CSSComputedStyleDeclaration.cpp: (WebCore::computedRotate): * css/parser/CSSPropertyParser.cpp: (WebCore::consumeRotate): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@276768 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The group resolved in #3305 that individual transform properties do not
distinguish between values specified using 2D syntax and values
specified using 3D syntax that produce the same matrices.
Fixes the individual transforms part of #3305.
cc @BorisChiou (who isn't in the list of reviewers I can choose from) and also @smfr (who is welcome to review as well, and can let me know if he wants me to wait for his review)