[css-fonts-5] vertical metrics overrides #6183
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfkthame
reviewed
Apr 6, 2021
litherum
force-pushed
the
vertical-metrics-overrides
branch
2 times, most recently
from
6fefb39
to
ac98908
Compare
jfkthame
reviewed
Apr 6, 2021
litherum
force-pushed
the
vertical-metrics-overrides
branch
from
ac98908
to
bf265b8
Compare
litherum
commented
Apr 6, 2021
litherum
force-pushed
the
vertical-metrics-overrides
branch
from
bf265b8
to
1d7f5ad
Compare
fantasai
requested changes
Apr 6, 2021
There was a problem hiding this comment.
I think you want the definition to be overriding the X vs. Y metrics (fundamentally), not as referencing the block/inline axes. And then describing the impact of that to be affecting the block axis only, with the second value only being used in upright vertical typesetting modes. (The actual definition of which metric gets used should be embedded into the part of the spec that uses the metric, rather than in the definition of how it gets overridden.)
Also, you need to be very clear that the second value defaults to normal, not to duplicating the first value.
|
Filed a pull request with updated wording as described in #6183 (review) at #6381 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6152.