[css-font-loading-3] FontFaceSet.clear() should not clear CSS-connected items #6553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed items The spec says in https://drafts.csswg.org/css-font-loading-3/#document-font-face-set: > The set entries for a document’s font source must be initially populated with all the CSS-connected FontFace objects from all of the CSS @font-face rules. And in https://drafts.csswg.org/css-font-loading-3/#font-face-css-connection > There is a two-way connection between [FontFace objects and @font-face rules]: any change made to a @font-face descriptor is immediately reflected in the corresponding FontFace attribute, and vice versa. And, finally, in https://drafts.csswg.org/css-font-loading-3/#dom-fontfaceset-clear > Remove all items from the FontFaceSet’s set entries. It seems like clear() shouldn't delete CSS-connected FontFaces. This is also what Firefox and Chrome both do. I'm updating WebKit to do this in https://bugs.webkit.org/show_bug.cgi?id=229643.
jfkthame
approved these changes
Aug 28, 2021
There was a problem hiding this comment.
I notice that delete method is explicit that it can not be used to remove CSS-connected faces; clear should similarly not affect them. So, LGTM.
|
Is this ready to merge, or do I need additional reviews? |
|
You submitted it late at night on a Friday, let me at least have Monday to look at it ^_^ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The spec says in https://drafts.csswg.org/css-font-loading-3/#document-font-face-set:
And in https://drafts.csswg.org/css-font-loading-3/#font-face-css-connection
And, finally, in https://drafts.csswg.org/css-font-loading-3/#dom-fontfaceset-clear
It seems like
clear()shouldn't delete CSS-connected FontFaces. This is also what Firefox and Chrome both do. I'm updating WebKit to do this in https://bugs.webkit.org/show_bug.cgi?id=229643.