[web-animations-2] Update ComputedEffectTiming #6712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flackr
requested changes
Oct 5, 2021
web-animations-2/Overview.bs
Outdated
| }; | ||
| </pre> | ||
|
|
||
| <div class='members'> | ||
|
|
||
| : <dfn dict-member for=ComputedEffectTiming>startTime</dfn> | ||
| :: The <a lt='animation effect start time'>start time</a> of this | ||
| <a>animation effect</a> in milliseconds or as a percentage of the | ||
| <a>animation effect</a> expressed as a double in milliseconds | ||
| if [=timeline duration=] is unresolved or as a percentage of |
There was a problem hiding this comment.
We seem to be using an unresolved timeline duration as an alternative to associated with a progress based timeline, however the latter is a better reason for the startTime to be expressed as a percentage - whereas if we had a finite time-based timeline I could see the time being expressed either way and most likely using a double for compatibility.
There was a problem hiding this comment.
Switched to being explicit about using % only with a progress based timeline. Switched ordering to avoid negative condition or otherwise, which feels awkward.
flackr
approved these changes
Oct 8, 2021
flackr
approved these changes
Oct 14, 2021
saschanaz
added a commit
to saschanaz/webref
that referenced
this pull request
Oct 23, 2021
It's [removed from level 2 spec](w3c/csswg-drafts#6712) and thus should be restored.
tidoust
pushed a commit
to w3c/webref
that referenced
this pull request
Oct 27, 2021
It's [removed from level 2 spec](w3c/csswg-drafts#6712) and thus should be restored.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[web-animations-2] Update ComputedEffectTiming
This PR fixes descriptions in ComputedEffectTiming to remove ambiguity over the return value types. Specifically, effects linked to animations with timelines that have an unresolved duration should return times expressed as doubles in milliseconds and not as CSSNumericValues. Only progress based animations should return their time values expressed as CSS.percent.
The progress attribute was previously changed to be of type CSSNumberish but without a description change. This property is a fraction and not a time. Thus, it should not have been changed. The change is reverted in this PR.
A few formatting fixers were applied to clearly show the type for each attribute in the "members" section.