Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[css-animations-1] Define indexed property getter for CSSKeyframesRule #7887

Merged
merged 1 commit into from
Nov 21, 2022
Merged

[css-animations-1] Define indexed property getter for CSSKeyframesRule #7887

merged 1 commit into from
Nov 21, 2022

Conversation

birtles
Copy link
Contributor

@birtles birtles commented Oct 17, 2022

Fixes #7684

@birtles
Copy link
Contributor Author

birtles commented Oct 30, 2022

@tabatkins @dbaron Any chance I could get your review on this? Thanks!

@birtles
Copy link
Contributor Author

birtles commented Nov 21, 2022

I've waited for over a month for review here so I might just go ahead and merge it.

@birtles birtles merged commit 354c40d into w3c:main Nov 21, 2022
@birtles birtles deleted the keyframes-getter branch November 21, 2022 03:33
@flackr
Copy link
Contributor

flackr commented Nov 21, 2022

Post-merge LGTM.

aarongable pushed a commit to chromium/chromium that referenced this pull request Feb 19, 2024
@amoseui
css: Expose length attribute of CSSKeyframesRule
a22c120 
For CSSKeyframesRule, getter and length was updated in the spec [1].
In Blink, getter had been already defined. According to the WebIDL
spec [2], interfaces that support indexed properties must define an
integer-typed attribute named "length".

This changes getter and exposes length attribute following the
spec [3]

[1] w3c/csswg-drafts#7887
[2] https://webidl.spec.whatwg.org/#idl-indexed-properties
[3] https://drafts.csswg.org/css-animations/#interface-csskeyframesrule-id

Bug: 1502758
Change-Id: I12bfebe39bf4fc87e04ddc5257c75b5ee7ed15e3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5069356
Commit-Queue: Euisang Lim <eui-sang.lim@samsung.com>
Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org>
Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1262337}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbaron dbaron Awaiting requested review from dbaron

@tabatkins tabatkins Awaiting requested review from tabatkins

@rniwa rniwa Awaiting requested review from rniwa

@flackr flackr Awaiting requested review from flackr

@graouts graouts Awaiting requested review from graouts

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[css-animations-1] CSSKeyframesRule should have index getter
2 participants
@birtles @flackr