Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[css-nav-1] Define properties with animation type #8422

Merged
merged 1 commit into from
Mar 1, 2023

Conversation

cdoublev
Copy link
Collaborator

@cdoublev cdoublev commented Feb 8, 2023

Adds Animation Type: not animatable to all property definitions. According to Web Animations 1, they would be otherwise considered as animatable:

Unless otherwise specified, all CSS properties are animatable.

@tabatkins
Copy link
Member

I presume these should be discretely animatable.

@cdoublev
Copy link
Collaborator Author

Would they accept mix()?

A mix() notation is invalid if either of its <declaration-value>s are invalid when interpreted as a whole value for the property the function is used in, or if the property using it is not animatable.

@tabatkins
Copy link
Member

I'm not sure I understand the purpose of the question. mix() just relies on the animation concept; if you can animate, you can mix().

@cdoublev
Copy link
Collaborator Author

cdoublev commented Mar 1, 2023

Forget it, I was trying to give an argument for not animatable, based on wrong thinking, indeed.

I am not sure exactly when a property should be not animatable, looking at the current list of not animatable properties.

Do you want me to set Animation type to discrete or close this PR and discuss the matter in a dedicated issue?

@tabatkins
Copy link
Member

Properties are only "not animatable" if they actually cause problems to animate. The animation-* properties are the obvious example, due to circularity, but a handful of other properties have been special-cased due to impl reasons. But absent any special reason, every property is animatable, just discretely if there's nothing else reasonable to do; that's why the Animations spec has that default in the first place.

Go ahead and just change these to discrete.

@tabatkins tabatkins merged commit 5f7361a into w3c:main Mar 1, 2023
@cdoublev cdoublev deleted the animation-type-issue-7 branch March 2, 2023 04:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants