Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[css-highlight-api-1] Add i18n warning about placement of range endpoints in text #8647

Merged
merged 4 commits into from
Mar 28, 2023
Merged

[css-highlight-api-1] Add i18n warning about placement of range endpoints in text #8647

merged 4 commits into from
Mar 28, 2023

Conversation

sanketj
Copy link
Member

@sanketj sanketj commented Mar 27, 2023

Address #5771

@sanketj sanketj assigned aphillips and frivoal and unassigned aphillips and frivoal Mar 27, 2023
@sanketj sanketj mentioned this pull request Mar 27, 2023
Closed
12 tasks
aphillips
aphillips suggested changes Mar 27, 2023
View reviewed changes
Copy link
Contributor

@aphillips aphillips left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this change. I made some terminology suggestions.

css-highlight-api-1/Overview.bs Outdated Show resolved Hide resolved
@sanketj @aphillips
Update css-highlight-api-1/Overview.bs
8177cde 
Co-authored-by: Addison Phillips <addisonI18N@gmail.com>
@sanketj
Copy link
Member Author

sanketj commented Mar 27, 2023

Thanks for this change. I made some terminology suggestions.

@aphillips Thanks for the suggestions and fixup. I've applied them.

@sanketj sanketj requested a review from aphillips March 27, 2023 20:22
@sanketj
Copy link
Member Author

sanketj commented Mar 28, 2023

@aphillips Any more feedback on this?

aphillips
aphillips approved these changes Mar 28, 2023
View reviewed changes
Copy link
Contributor

@aphillips aphillips left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thank you!

@sanketj sanketj merged commit 119e4fb into w3c:main Mar 28, 2023
@sanketj sanketj deleted the highlight-api-range-i18n-warning branch March 28, 2023 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aphillips aphillips aphillips approved these changes

@frivoal frivoal Awaiting requested review from frivoal

Assignees
No one assigned
Labels
css-highlight-api-1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@sanketj @aphillips @frivoal @xfq