-
Notifications
You must be signed in to change notification settings - Fork 637
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reorganize Concepts in View Transitions spec #8918
Conversation
a7989a9
to
8c7973c
Compare
The [=view transition layer=] is a sibling of this stacking context. | ||
|
||
- The [=view transition layer=] paints after the stacking context for the [=document element=] and [=Document/top layer=]. | ||
This includes the filters and effects that are applied to the [=document element=]. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While we're here. Should the line about filters go to the second point, "this" is ambiguous in the sentence.
"If the ''::view-transition'' pseudo-element exists,
a new [=stacking context=] is created for the [=document element=] and the [=Document/top layer=].
This [=stacking context=] includes the filters and effects that are applied to the [=document element=].
The [=view transition layer=] is a sibling of this stacking context.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I rewrote this part in #8927 so I think we should leave it untouched here. :)
* Make rules about grouping/flattening due to view-transition-name into a subsection of the property definition. * Expand out the text of the 3D flattening rule, so that it is reasonably self-evident without following the link. * Rename “involved in a view transition” to “captured in a view transition” to better link related concepts by using more closely related terminology. * Move transition suppression impacts under its definition, since these impacts are why that concept exists.
…the algorithms that use them. And pull out Monkey Patches into a top-level section, since they're also effectively interfaces with the world outside this spec.
8c7973c
to
274d13b
Compare
This patch splits apart the Concepts section which was a collection of random ideas and consolidates the various parts with related content.
It might be easier to review commit by commit.