Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[css-pseudo-4][editorial] Fixed typo in example #9024

Merged
merged 1 commit into from
Jul 2, 2023

Conversation

SebastianZ
Copy link
Contributor

This adds the missin word "styled" to the examples.

Fixes #9023

@SebastianZ SebastianZ merged commit 0b2cf70 into w3c:main Jul 2, 2023
1 check passed
@LarryLACa
Copy link

Flowing the inserted text at the right margin was tricky.
because of the long hyphenated terms like first-line and pseudo-element,
which may or may not break and wrap on the right at the '-',
when pushed to the right by the 'styled' insertion flow.

The #9024 fix, inserting 'styled' and extending that line on the right
without page width wrap, seems to extend the line
past the right margin implied by the preceding lines.

Can you give me a link to the updateddraft spec file,
so we can see the end result visually?

@LarryLACa
Copy link

I found the Editors Draft page:
https://drafts.csswg.org/css-pseudo-4/
with the displayed visuals of Example 2.
The repaired 'be styled by' lines are too long.
Their right margin wrap is inconsistent with the preceding lines.

See my rework here:
main...LarryLACa:csswg-drafts:patch-1

SebastianZ added a commit that referenced this pull request Jul 4, 2023
After #9024, the line breaks were a bit off, which this change corrects.
@SebastianZ
Copy link
Contributor Author

You're right. I didn't check the line lengths of the examples.

I've merged your patch in #9031. Thanks a lot, @LarryLACa!

Sebastian

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[css-pseudo] [css-pseudo-4] Draft text: First-Line Text example missing 'styled'
2 participants