Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[css-view-transitions-1] A few clarifications and nits #9028

Merged
merged 5 commits into from Jul 12, 2023

Conversation

noamr
Copy link
Collaborator

@noamr noamr commented Jul 4, 2023

  • Separated view transition activation to own algorithm, to prepare for cross-doc
  • Clarifying that new elements are invisible during the transition
  • Changed type of image from ImageData to 2D-bitmap
  • Fixed a few broken refs

See #8958

noamr added 2 commits July 4, 2023 17:39
- Separated view transition activation to own algorithm, to prepare for cross-doc
- Clarifying that new elements are invisible during the transition
- Changed type of image from ImageData to 2D-bitmap
- Fixed a few broken refs

See w3c#8958
@noamr noamr requested a review from khushalsagar July 4, 2023 15:00
@noamr
Copy link
Collaborator Author

noamr commented Jul 4, 2023

@fantasai FYI

css-view-transitions-1/Overview.bs Show resolved Hide resolved
css-view-transitions-1/Overview.bs Outdated Show resolved Hide resolved
css-view-transitions-1/Overview.bs Show resolved Hide resolved
css-view-transitions-1/Overview.bs Outdated Show resolved Hide resolved
noamr and others added 3 commits July 12, 2023 09:24
Co-authored-by: Khushal Sagar <63884798+khushalsagar@users.noreply.github.com>
@khushalsagar khushalsagar merged commit 631a3d5 into w3c:main Jul 12, 2023
1 check passed
Copy link
Collaborator

@fantasai fantasai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Editorial comments

@@ -787,6 +789,9 @@ urlPrefix: https://wicg.github.io/navigation-api/; type: interface;
since that results in a circular dependency.
Therefore, the [=view transition layer=] is a sibling of all other content.

When a {{Document}}'s [=document/active view transition=]'s [=ViewTransition/phase=] is "`animating`",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this have both <code> and quotes?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(I'm not familiar with the conventions here, so just asking.)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think so. This spec uses <code> for syntax which can be used by an author. phase is internal UA state.

css-view-transitions-1/Overview.bs Show resolved Hide resolved
Comment on lines +1656 to +1657
* Effects applied on the element and its descendants, such as 'opacity' and 'filter', are applied to the capture.
Effects applied to the element from its ancestors are ignored.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where is “Effects” as used here defined?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is a good question. Is there a definition in CSS for visual effects on an element which affect its descendants? The list here is the closest I've seen in documentation. I can also just add all these properties explicitly but nicer if we can have one definition to cross-reference.

css-view-transitions-1/Overview.bs Show resolved Hide resolved
Copy link
Member

@khushalsagar khushalsagar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#9143 takes care of the remaining comments.

@@ -787,6 +789,9 @@ urlPrefix: https://wicg.github.io/navigation-api/; type: interface;
since that results in a circular dependency.
Therefore, the [=view transition layer=] is a sibling of all other content.

When a {{Document}}'s [=document/active view transition=]'s [=ViewTransition/phase=] is "`animating`",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think so. This spec uses <code> for syntax which can be used by an author. phase is internal UA state.

css-view-transitions-1/Overview.bs Show resolved Hide resolved
css-view-transitions-1/Overview.bs Show resolved Hide resolved
Comment on lines +1656 to +1657
* Effects applied on the element and its descendants, such as 'opacity' and 'filter', are applied to the capture.
Effects applied to the element from its ancestors are ignored.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is a good question. Is there a definition in CSS for visual effects on an element which affect its descendants? The list here is the closest I've seen in documentation. I can also just add all these properties explicitly but nicer if we can have one definition to cross-reference.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants