-
Notifications
You must be signed in to change notification settings - Fork 642
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[css-text-4] Deduplication of normative text and editorial reorganization #9299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A leftover from Level 3: which elements’ 'line-break', 'word-break', and 'overflow-wrap' properties
control the determination of [=soft wrap opportunities=]
at such boundaries
is undefined in Level 3. |
Move the mandatory line breaking class that related to keeping characters together into the same sentence as the others, and outside of the sentence that talks about respecting those that force a break.
Merge the first sentence of the second paragraph of #text-wrap-shorthand with the second bullet of #line-break-details, and put the result in #text-wrap-mode
Merge the remaining sentence of the second paragraph of #text-wrap-shorthand with the corresponding bullet of #line-break-details (the second one).
…ion to CM or SG This is already implied by the normative text, but highlight it as a note.
The #line-break-details section already has a more developed version of the same text. Keep that one.
…ine Breaking Details
…ing" Also include a cross reference to it from the definition of 'overflow-wrap-mode: wrap'.
… and Word Boundaries
…ions The first two paragraph of the intro to #line-breaking become the introduction for #text-wrapping
Since 'wrap-inside: avoid' is a better alternative to some situations where nowrap is used, moving them closer helps with discovery.
This brings text-wrap-mode and the wrap-inside/before/after properties closer to each other, which is good since they control similar things (can you wrap?).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some redundant text had appeared through parallel history in css-text-3 and css-text-4. This PR deduplicates them, and takes the opportunity for shuffling some paragraphs and sections around to try and make things a little more coherent.