Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[css-text-4] Deduplication of normative text and editorial reorganization #9299

Merged
merged 14 commits into from
Sep 5, 2023

Conversation

frivoal
Copy link
Collaborator

@frivoal frivoal commented Sep 3, 2023

Some redundant text had appeared through parallel history in css-text-3 and css-text-4. This PR deduplicates them, and takes the opportunity for shuffling some paragraphs and sections around to try and make things a little more coherent.

@frivoal
Copy link
Collaborator Author

frivoal commented Sep 3, 2023

@yarusome
Copy link

yarusome commented Sep 4, 2023

A leftover from Level 3:

which elements’ 'line-break', 'word-break', and 'overflow-wrap' properties
control the determination of [=soft wrap opportunities=]
at such boundaries
is undefined in Level 3.

Move the mandatory line breaking class that related to keeping
characters together into the same sentence as the others, and outside of
the sentence that talks about respecting those that force a break.
Merge the first sentence of the second paragraph of #text-wrap-shorthand
with the second bullet of #line-break-details, and put the result
in #text-wrap-mode
Merge the remaining sentence of the second paragraph
of #text-wrap-shorthand with the corresponding bullet
of #line-break-details (the second one).
…ion to CM or SG

This is already implied by the normative text, but highlight it as a
note.
The #line-break-details section already has a more developed version of
the same text. Keep that one.
…ing"

Also include a cross reference to it from the definition of
'overflow-wrap-mode: wrap'.
…ions

The first two paragraph of the intro to #line-breaking become the
introduction for #text-wrapping
Since 'wrap-inside: avoid' is a better alternative to some situations
where nowrap is used, moving them closer helps with discovery.
This brings text-wrap-mode and the wrap-inside/before/after properties
closer to each other, which is good since they control similar things
(can you wrap?).
@frivoal
Copy link
Collaborator Author

frivoal commented Sep 5, 2023

A leftover from Level 3

Fixed in ad66499

@frivoal frivoal marked this pull request as ready for review September 5, 2023 08:44
@frivoal frivoal merged commit 631d25e into w3c:main Sep 5, 2023
1 check passed
@frivoal frivoal deleted the txt-reorg branch September 5, 2023 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants