Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[css-anchor-position-1] Make snapshotted scroll offset per-axis #9347

Merged
merged 3 commits into from
Sep 28, 2023

Conversation

xiaochengh
Copy link
Contributor

For #9239

Define whether there's a snapshotted scroll offset on each axis separately, and then revise the concept of snapshotted scroll snapshot and how it's used accordingly.

@xiaochengh
Copy link
Contributor Author

Wait, this doesn't seem to work for the multiple anchor case.

Say the element uses anchor --a in the x axis and anchor --b in the y axis, and both anchors are in the same scroller. We still want to do scroll adjustments in both axes, but there's only one default anchor.

I think we should refine it into: do adjustment in an axis if there's reference to any anchor element in the same scroller (but not any descendant scroller) as the default anchor in that axis.

@xiaochengh
Copy link
Contributor Author

Fixed it, PTAL.

css-anchor-position-1/Overview.bs Outdated Show resolved Hide resolved
@tabatkins tabatkins merged commit b5d09d9 into w3c:main Sep 28, 2023
1 check passed
@xiaochengh xiaochengh deleted the fix-scroll-offset-axis branch October 4, 2023 00:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants