[css-transforms-2] Make backface-visibility:hidden create a stacking context and containing block when participating in a 3D rendering context. #9348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergioandrade
approved these changes
Sep 13, 2023
…context and containing block when participating in a 3D rendering context. (w3c#918)
mattwoodrow
force-pushed
the
backface-containing-block
branch
from
76f270c
to
bf4d4c9
Compare
webkit-commit-queue
pushed a commit
to mattwoodrow/WebKit
that referenced
this pull request
Sep 14, 2023
…ining block. https://bugs.webkit.org/show_bug.cgi?id=261532 <rdar://114732608> Reviewed by Simon Fraser. As of w3c/csswg-drafts#9348, backface-visibility:hidden should create a containing block and stacking context, if the element participates in a 3D rendering context. This adds a new preference for this change (currently disabled, until other engines are ready to ship the change), and makes the code changes. It also removes old WPTs that relied on the previous behaviour, and replaces them with new ones testing the new spec. * LayoutTests/TestExpectations: * LayoutTests/imported/w3c/web-platform-tests/css/css-transforms/backface-visibility-hidden-002-expected.html: Copied from LayoutTests/imported/w3c/web-platform-tests/css/css-transforms/backface-visibility-hidden-002.tentative-expected.html. * LayoutTests/imported/w3c/web-platform-tests/css/css-transforms/backface-visibility-hidden-002.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-transforms/backface-visibility-hidden-002.tentative.html. * LayoutTests/imported/w3c/web-platform-tests/css/css-transforms/backface-visibility-hidden-003-expected.html: Copied from LayoutTests/imported/w3c/web-platform-tests/css/css-transforms/backface-visibility-hidden-002.tentative-expected.html. * LayoutTests/imported/w3c/web-platform-tests/css/css-transforms/backface-visibility-hidden-003-ref.html: * LayoutTests/imported/w3c/web-platform-tests/css/css-transforms/backface-visibility-hidden-003.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-transforms/backface-visibility-hidden-003.tentative-expected.html: Removed. * LayoutTests/imported/w3c/web-platform-tests/css/css-transforms/backface-visibility-hidden-003.tentative.html: Removed. * LayoutTests/imported/w3c/web-platform-tests/css/css-transforms/backface-visibility-hidden-004-expected.html: Copied from LayoutTests/imported/w3c/web-platform-tests/css/css-transforms/backface-visibility-hidden-002.tentative-expected.html. * LayoutTests/imported/w3c/web-platform-tests/css/css-transforms/backface-visibility-hidden-004.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-transforms/backface-visibility-hidden-004.tentative-expected.html: Removed. * LayoutTests/imported/w3c/web-platform-tests/css/css-transforms/backface-visibility-hidden-004.tentative.html: Removed. * LayoutTests/imported/w3c/web-platform-tests/css/css-transforms/backface-visibility-hidden-005-expected.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-transforms/backface-visibility-hidden-002.tentative-expected.html. * LayoutTests/imported/w3c/web-platform-tests/css/css-transforms/backface-visibility-hidden-005.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-transforms/backface-visibility-hidden-005.tentative-expected.html: Removed. * LayoutTests/imported/w3c/web-platform-tests/css/css-transforms/backface-visibility-hidden-005.tentative.html: Removed. * LayoutTests/imported/w3c/web-platform-tests/css/css-transforms/backface-visibility-hidden-animated-002-expected.html: Removed. * LayoutTests/imported/w3c/web-platform-tests/css/css-transforms/backface-visibility-hidden-animated-002.html: Removed. * Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml: * Source/WebCore/rendering/RenderBox.cpp: (WebCore::RenderBox::updateFromStyle): (WebCore::RenderBox::computeHasTransformRelatedProperty const): * Source/WebCore/rendering/RenderBox.h: * Source/WebCore/rendering/RenderLayer.cpp: (WebCore::RenderLayer::clippingRootForPainting const): * Source/WebCore/style/StyleAdjuster.cpp: (WebCore::Style::Adjuster::adjust const): Canonical link: https://commits.webkit.org/267980@main
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first (simpler) half of what was discussed in #918.
Will try write some new tentative tests for this too.