Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[css-fonts-4] Make color interpolation method optional in palette-mix() #9376

Closed
wants to merge 1 commit into from

Conversation

cdoublev
Copy link
Collaborator

<color-interpolation-method> is defined as optional in prose for <palette-mix()>:

When not specified otherwise the is in oklab as recommended by CSS Color 5 § 7.1 Color Space for Interpolation.

But not in its value definition:

palette-mix(<color-interpolation-method> , [ [normal | light | dark | <palette-identifier> | <palette-mix()> ] && <percentage [0,100]>? ]#{2})

I suppose this is an oversight.

@svgeesus
Copy link
Contributor

I think the prose is incorrect, because in discussions it was clear that palette-mix() was closely based on color-mix() where the color-interpolation-method is not optional.

But I think there will be ongoing discussion on this, so let's leave this PR open while that happens.

@svgeesus
Copy link
Contributor

svgeesus commented Jan 9, 2024

Further discussion aligned palette-mix() with color-mix(), so the color interpolation method is (per grammar) not optional.

Closing this PR therefore and I will remove the prose mention of it being optional.

@svgeesus svgeesus closed this Jan 9, 2024
@svgeesus
Copy link
Contributor

svgeesus commented Jan 9, 2024

Fixed by 1a415a2

@cdoublev cdoublev deleted the patch-1 branch January 9, 2024 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants