Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[css-view-transitions-2] A few minor edits #9527

Merged
merged 3 commits into from
Oct 26, 2023
Merged

[css-view-transitions-2] A few minor edits #9527

merged 3 commits into from
Oct 26, 2023

Conversation

noamr
Copy link
Collaborator

@noamr noamr commented Oct 26, 2023

  • Specify paint holding
  • Fix missing |transition| var
  • Allow an empty list in the type descriptor

Closes #8888

* Specify paint holding
* Fix missing |transition| var
* Allow an empty list in the type descriptor
@@ -523,6 +520,8 @@ The {{CSSViewTransitionRule}} represents a ''@view-transition'' rule.
1. Set |oldDocument|'s [=active view transition=] to |outboundTransition|.

Note: The process continues in [=setup view transition=], via [=perform pending transition operations=].

1. The user agent should display the currently displayed frame until |newDocument| is [=revealed=], or until its [=active view transition=]'s [=ViewTransition/phase=] is "`done`".
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trying to reason about why we need "or until its [=active view transition=]'s [=ViewTransition/phase=] is "done". Is this for the case where the transition is skipped before reveal? I think that can only happen in the reveal algorithm here anyway which is right before we hit "revealed".

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the document navigates away or an SPA nav is initiated.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah ok cool. Slight suggestion on wording:

The user agent should display the currently displayed frame until either:

  • |newDocument| is [=revealed=]
  • its [=active view transition=]'s [=ViewTransition/phase=] is "done"

Non-normative note to document the cases you mentioned for the second condition.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM % this comment.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

css-view-transitions-2/Overview.bs Outdated Show resolved Hide resolved
@khushalsagar
Copy link
Member

Leaving a note about activating the transition after dispatching the reveal event. So authors have a script hook to set up VT names.

@noamr noamr merged commit c95d80c into w3c:main Oct 26, 2023
1 check passed
@noamr noamr deleted the vt2-edits branch October 26, 2023 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[css-view-transitions-2] Hold paint of old Document until new Document draws a frame
2 participants