[cssom-view-1] Add more checkVisibility dictionary properties #9549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Nov 2, 2023
This is to implement w3c/csswg-drafts#9549 R=jarhar@chromium.org Change-Id: Id5d8c700019a257d8dc3fc79436eefc427e8aac3
|
@vmpstr Can you rename the checkContentVisibilityAuto option from: web-platform-tests/wpt#42829 as well? I added these tests only tentatively. |
|
Yep, doing that as part of the implementation. Thank you for pointing this out |
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Nov 3, 2023
This is to implement w3c/csswg-drafts#9549 R=jarhar@chromium.org Change-Id: Id5d8c700019a257d8dc3fc79436eefc427e8aac3
aarongable
pushed a commit
to chromium/chromium
that referenced
this pull request
Nov 3, 2023
This is to implement w3c/csswg-drafts#9549 R=jarhar@chromium.org Change-Id: Id5d8c700019a257d8dc3fc79436eefc427e8aac3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5003245 Auto-Submit: Vladimir Levin <vmpstr@chromium.org> Commit-Queue: Joey Arhar <jarhar@chromium.org> Reviewed-by: Joey Arhar <jarhar@chromium.org> Cr-Commit-Position: refs/heads/main@{#1219676}
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Nov 3, 2023
This is to implement w3c/csswg-drafts#9549 R=jarhar@chromium.org Change-Id: Id5d8c700019a257d8dc3fc79436eefc427e8aac3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5003245 Auto-Submit: Vladimir Levin <vmpstr@chromium.org> Commit-Queue: Joey Arhar <jarhar@chromium.org> Reviewed-by: Joey Arhar <jarhar@chromium.org> Cr-Commit-Position: refs/heads/main@{#1219676}
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Nov 3, 2023
This is to implement w3c/csswg-drafts#9549 R=jarhar@chromium.org Change-Id: Id5d8c700019a257d8dc3fc79436eefc427e8aac3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5003245 Auto-Submit: Vladimir Levin <vmpstr@chromium.org> Commit-Queue: Joey Arhar <jarhar@chromium.org> Reviewed-by: Joey Arhar <jarhar@chromium.org> Cr-Commit-Position: refs/heads/main@{#1219676}
nt1m
reviewed
Nov 6, 2023
smfr
reviewed
Nov 6, 2023
| @@ -1161,6 +1161,9 @@ dictionary ScrollIntoViewOptions : ScrollOptions { | |||
| dictionary CheckVisibilityOptions { | |||
| boolean checkOpacity = false; | |||
There was a problem hiding this comment.
Please add a Note that says that checkVisibilityCSS and checkOpacity are deprecated.
There was a problem hiding this comment.
We haven't resolved to deprecate these. I've added a note that says they are historical names that have aliases that match the new naming scheme. I suspect we want to revisit at CSSWG if we want to deprecate the names though.
There was a problem hiding this comment.
I think it's fine to call them deprecated IMO. I don't feel strongly either way tho. Assuming @smfr is fine with the current wording feel free to merge.
webkit-commit-queue
pushed a commit
to pxlcoder/WebKit
that referenced
this pull request
Nov 6, 2023
https://bugs.webkit.org/show_bug.cgi?id=264062 rdar://117821444 Reviewed by Tim Nguyen. Implement w3c/csswg-drafts#9549. * LayoutTests/imported/w3c/web-platform-tests/css/cssom-view/checkVisibility.html: * Source/WebCore/dom/CheckVisibilityOptions.h: * Source/WebCore/dom/CheckVisibilityOptions.idl: * Source/WebCore/dom/Element.cpp: (WebCore::Element::checkVisibility): Canonical link: https://commits.webkit.org/270283@main
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Nov 14, 2023
… aliases and c-v auto, a=testonly Automatic update from web-platform-tests checkVisibility: Add extra parameters as aliases and c-v auto This is to implement w3c/csswg-drafts#9549 R=jarhar@chromium.org Change-Id: Id5d8c700019a257d8dc3fc79436eefc427e8aac3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5003245 Auto-Submit: Vladimir Levin <vmpstr@chromium.org> Commit-Queue: Joey Arhar <jarhar@chromium.org> Reviewed-by: Joey Arhar <jarhar@chromium.org> Cr-Commit-Position: refs/heads/main@{#1219676} -- wpt-commits: 07417e7c2e42620f8f06cde13d51a928c978b0d3 wpt-pr: 42929
vinnydiehl
pushed a commit
to vinnydiehl/mozilla-unified
that referenced
this pull request
Nov 15, 2023
… aliases and c-v auto, a=testonly Automatic update from web-platform-tests checkVisibility: Add extra parameters as aliases and c-v auto This is to implement w3c/csswg-drafts#9549 R=jarhar@chromium.org Change-Id: Id5d8c700019a257d8dc3fc79436eefc427e8aac3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5003245 Auto-Submit: Vladimir Levin <vmpstr@chromium.org> Commit-Queue: Joey Arhar <jarhar@chromium.org> Reviewed-by: Joey Arhar <jarhar@chromium.org> Cr-Commit-Position: refs/heads/main@{#1219676} -- wpt-commits: 07417e7c2e42620f8f06cde13d51a928c978b0d3 wpt-pr: 42929
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Nov 16, 2023
… aliases and c-v auto, a=testonly Automatic update from web-platform-tests checkVisibility: Add extra parameters as aliases and c-v auto This is to implement w3c/csswg-drafts#9549 R=jarharchromium.org Change-Id: Id5d8c700019a257d8dc3fc79436eefc427e8aac3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5003245 Auto-Submit: Vladimir Levin <vmpstrchromium.org> Commit-Queue: Joey Arhar <jarharchromium.org> Reviewed-by: Joey Arhar <jarharchromium.org> Cr-Commit-Position: refs/heads/main{#1219676} -- wpt-commits: 07417e7c2e42620f8f06cde13d51a928c978b0d3 wpt-pr: 42929 UltraBlame original commit: 16c04f34de7dd94c09609af2623901d921cf85d4
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Nov 16, 2023
… aliases and c-v auto, a=testonly Automatic update from web-platform-tests checkVisibility: Add extra parameters as aliases and c-v auto This is to implement w3c/csswg-drafts#9549 R=jarharchromium.org Change-Id: Id5d8c700019a257d8dc3fc79436eefc427e8aac3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5003245 Auto-Submit: Vladimir Levin <vmpstrchromium.org> Commit-Queue: Joey Arhar <jarharchromium.org> Reviewed-by: Joey Arhar <jarharchromium.org> Cr-Commit-Position: refs/heads/main{#1219676} -- wpt-commits: 07417e7c2e42620f8f06cde13d51a928c978b0d3 wpt-pr: 42929 UltraBlame original commit: 16c04f34de7dd94c09609af2623901d921cf85d4
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Nov 16, 2023
… aliases and c-v auto, a=testonly Automatic update from web-platform-tests checkVisibility: Add extra parameters as aliases and c-v auto This is to implement w3c/csswg-drafts#9549 R=jarharchromium.org Change-Id: Id5d8c700019a257d8dc3fc79436eefc427e8aac3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5003245 Auto-Submit: Vladimir Levin <vmpstrchromium.org> Commit-Queue: Joey Arhar <jarharchromium.org> Reviewed-by: Joey Arhar <jarharchromium.org> Cr-Commit-Position: refs/heads/main{#1219676} -- wpt-commits: 07417e7c2e42620f8f06cde13d51a928c978b0d3 wpt-pr: 42929 UltraBlame original commit: 16c04f34de7dd94c09609af2623901d921cf85d4
emilio
approved these changes
Nov 18, 2023
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Nov 20, 2023
… aliases and c-v auto, a=testonly Automatic update from web-platform-tests checkVisibility: Add extra parameters as aliases and c-v auto This is to implement w3c/csswg-drafts#9549 R=jarhar@chromium.org Change-Id: Id5d8c700019a257d8dc3fc79436eefc427e8aac3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5003245 Auto-Submit: Vladimir Levin <vmpstr@chromium.org> Commit-Queue: Joey Arhar <jarhar@chromium.org> Reviewed-by: Joey Arhar <jarhar@chromium.org> Cr-Commit-Position: refs/heads/main@{#1219676} -- wpt-commits: 07417e7c2e42620f8f06cde13d51a928c978b0d3 wpt-pr: 42929
jamienicol
pushed a commit
to jamienicol/gecko
that referenced
this pull request
Nov 20, 2023
… aliases and c-v auto, a=testonly Automatic update from web-platform-tests checkVisibility: Add extra parameters as aliases and c-v auto This is to implement w3c/csswg-drafts#9549 R=jarhar@chromium.org Change-Id: Id5d8c700019a257d8dc3fc79436eefc427e8aac3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5003245 Auto-Submit: Vladimir Levin <vmpstr@chromium.org> Commit-Queue: Joey Arhar <jarhar@chromium.org> Reviewed-by: Joey Arhar <jarhar@chromium.org> Cr-Commit-Position: refs/heads/main@{#1219676} -- wpt-commits: 07417e7c2e42620f8f06cde13d51a928c978b0d3 wpt-pr: 42929
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Nov 21, 2023
… aliases and c-v auto, a=testonly Automatic update from web-platform-tests checkVisibility: Add extra parameters as aliases and c-v auto This is to implement w3c/csswg-drafts#9549 R=jarharchromium.org Change-Id: Id5d8c700019a257d8dc3fc79436eefc427e8aac3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5003245 Auto-Submit: Vladimir Levin <vmpstrchromium.org> Commit-Queue: Joey Arhar <jarharchromium.org> Reviewed-by: Joey Arhar <jarharchromium.org> Cr-Commit-Position: refs/heads/main{#1219676} -- wpt-commits: 07417e7c2e42620f8f06cde13d51a928c978b0d3 wpt-pr: 42929 UltraBlame original commit: fec2ac190e9d4d441e15030b3b20974ffdf8cd87
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Nov 21, 2023
… aliases and c-v auto, a=testonly Automatic update from web-platform-tests checkVisibility: Add extra parameters as aliases and c-v auto This is to implement w3c/csswg-drafts#9549 R=jarharchromium.org Change-Id: Id5d8c700019a257d8dc3fc79436eefc427e8aac3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5003245 Auto-Submit: Vladimir Levin <vmpstrchromium.org> Commit-Queue: Joey Arhar <jarharchromium.org> Reviewed-by: Joey Arhar <jarharchromium.org> Cr-Commit-Position: refs/heads/main{#1219676} -- wpt-commits: 07417e7c2e42620f8f06cde13d51a928c978b0d3 wpt-pr: 42929 UltraBlame original commit: fec2ac190e9d4d441e15030b3b20974ffdf8cd87
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Nov 21, 2023
… aliases and c-v auto, a=testonly Automatic update from web-platform-tests checkVisibility: Add extra parameters as aliases and c-v auto This is to implement w3c/csswg-drafts#9549 R=jarharchromium.org Change-Id: Id5d8c700019a257d8dc3fc79436eefc427e8aac3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5003245 Auto-Submit: Vladimir Levin <vmpstrchromium.org> Commit-Queue: Joey Arhar <jarharchromium.org> Reviewed-by: Joey Arhar <jarharchromium.org> Cr-Commit-Position: refs/heads/main{#1219676} -- wpt-commits: 07417e7c2e42620f8f06cde13d51a928c978b0d3 wpt-pr: 42929 UltraBlame original commit: fec2ac190e9d4d441e15030b3b20974ffdf8cd87
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[cssom-view-1] Add more checkVisibility dictionary properties
Fixes #9474
Fixes #9487